OK I can do that, agreed that is an isolated change. Should I go off the
trunk or the 2.10.4 tag?
-Richard
------ Original Message ------
From: "Robert Scholte" <rfscho...@apache.org>
To: "Maven Developers List" <dev@maven.apache.org>
Sent: 6/29/2016 1:34:19 PM
Subject: Re: [VOTE] Release Apache Maven Javadoc Plugin version 2.10.4
Let's start with a simple segment: don't update the file if there are
no changes. That's an isolated issue.
You suggestion is to do a String compare, which seems to me quite
expensive with large files. Instead I would introduce a changed-flag.
AFAIK all rewriting methods are now void-methods. Return true if
changed; if changed then rewrite file.
After that we can go for the next part.
Robert
On Wed, 29 Jun 2016 06:30:34 +0200, Richard Sand <rs...@idfconnect.com>
wrote:
Hi Maven Developers - now that Javadoc plugin 2.10.4 is released and
work has commenced on the 3.0 version, can we revisit the patch I
submitted for MJAVADOC-452? Its difficult to break the patch into
smaller patches because most of the fixes are interrelated, but I'd be
happy to recreate the fixes on the 2.10.4 tag or the latest trunk. How
can I help?
-Richard
Richard Sand <mailto:rs...@idfconnect.com>
June 8, 2016 at 2:11 PM
Hi Robert,
For the skip parameter, the test is very simple. Usage of the fix
goal
without disabling CLIRR will result in a loop where fix invokes
clirr,
and clirr runs fix.
I understand your reticence about this skip option - but in scenarios
where one wants to have the plugin execute automatically with
"force",
having an override is useful. So from my perspective it is useful and
it follows the patterns that other plugins use, including the javadoc
plugin - just this goal is missing a skip option.
I didn't break the patch up into smaller patches, but I did annotate
all of the changes that the patch performs line-by-line in the Jira
case. I hope that helps "demystify" the fixes.
Best regards,
Richard
Robert Scholte <mailto:rfscho...@apache.org>
June 8, 2016 at 2:01 PM
Hi Richard,
this release is to push the final 2.x version before moving to a pure
Maven 3 implementation (there were quite some fixed issues waiting to
be released).
Once released I will continue, also including some Java9 related
improvements. That will give me enough time to go through your
patches. Since you weren't able to split it into smaller pieces I
need
more time to verify and apply it.
thanks,
Robert
ps. In case you are still convinced the skip parameter is required,
you need a complete testcase to show it to me. In general *I* won't
apply any requests to add a skip parameter, there are often better
solutions.
On Wed, 08 Jun 2016 00:53:33 +0200, Richard Sand
<rs...@idfconnect.com> wrote:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
