Hi Rajiv,
I have taken another look into your updated pull request...
We usually don't use asterik imports...and furthermore you don't follow
the code style guide we have:
http://maven.apache.org/developers/conventions/code.html
If you runn a full build of what you have changed checkstyle should fail
here already...and give you a hint that the code style you have used is
not correct...
Kind regards
Karl Heinz
On 7/22/16 7:50 PM, Rajiv Jain wrote:
Hi
Thanks for the quick reply. I will give that ago.
Ignore me for the jre. My details are:
mvn --version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /Users/rajivpjs/Desktop/apache-maven-3.3.9/apache-maven-3.3.9
For some reason I thought maven home is
Users/rajivpsj/Desktop/apache-maven-3.3.9/apache-maven-3.3.9/jre
Sorry for the confusion.
Thanks once again.
Just out of question, I raised a pull request a few days ago MNG-5910
(https://github.com/apache/maven/pull/88). There was one review comment
which I have fixed and I think this can be merged in. Could someone
please look at and if fine then we can merge and close the pull request?
Regards,
Rajiv
On 22 Jul 2016, at 18:33, Karl Heinz Marbaise <[email protected]
<mailto:[email protected]>> wrote:
Hi,
On 7/22/16 7:17 PM, Rajiv Jain wrote:
Hi
I have recently started to make contributions to the Apache Maven
source code.
I would like to know that if I wish to build a maven project using my
changes how would I do this?
You can build Maven Core by using the following and let also the
distribution being copied to a particular directory like this:
mvn
-DdistributionTargetFolder=/Users/kama/tools/maven-test/apache-maven-3.4.0-SNAPSHOT
clean package
I have a particular folder for the test version which I build from
Maven core .
Now if I like to use the build Maven version I simply use it directly:
~/tools/maven-test/apache-maven-3.4.0-SNAPSHOT/bin/mvn clean package
So I use the build version here...
Apart from that if you are making changes to Maven Core you should
become familiar with the integration tests suite...
http://maven.apache.org/core-its/core-it-suite/
I am using a mac, and my current unmodified maven is pointing to the
jre folder to maven home.
>How can I point my modified changes to maven home?
>
Is this possible? What are the options?
What I don't understand is what you mean by "pointing to jre folder to
maven home" ?
You know that Maven needs a JDK and not an JRE ?
I simply call it directly or just add it to my Path. I have written
some scripts to change the Maven version I'm using via links:
which look like this:
#!/bin/bash
sudo rm /usr/share/maven
sudo ln -s /usr/share/java/apache-maven-3.3.9 /usr/share/maven
And the path /usr/shared/maven/bin is part of my PATH....
No M2_HOME, MAVEN_HOME set...
Kind regards.
Karl Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
