Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/118#discussion_r78076018 --- Diff: surefire-integration-tests/src/test/resources/junit5/src/test/java/junit5/JUnit5Test.java --- @@ -53,13 +53,13 @@ public void tearDown() @Test public void testSetUp() { - assertTrue( setUpCalled, "setUp was not called" ); + Assertions.assertTrue( setUpCalled, "setUp was not called" ); --- End diff -- It's up to your taste:) I like using it because especially in the assertion statements are verbose and if you read them in whole line then it sounds like sentence you read in news, very narrative. And therefore the class name does not have meaning to make it more verbose, it's just only a place where the function is stored. The line width is limited to 120 chars which forces me to decide on how to type complete statement without breaking the line and without wrapping with nested statement.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org