On Mon, 26 Sep 2016 14:17:59 +0200, Stephen Connolly
<[email protected]> wrote:
https://www.youtube.com/watch?v=Wef9p4ykNMM
Some questions Robert had:
1. Do we need module-info.java for src/main/test?
* Well if I'm creating a test-jar to allow reuse of the tests in
downstream
projects, then yes we do
So there are 2 cases:
- src/main/java without module-info.java + src/test/java with
module-info.java: this one is really weird, but would mean that all
dependencies must end up on the modulepath
- src/main/java with module-info.java + src/test/java with
module-info.java: this will only work if the moduleNames are different AND
if they don't export the same packages (this is not a Maven issue but a
jigsaw fact). I've always considered test-jars as some kind of
anti-pattern, and this will hopefully motivate others to make a separate
Maven module for it.
2. Is Animal-Sniffer relevant now that we have --release N?
* Well more correctly the question is more whether the JVM signatures are
relevant. There is still validity in checking other API contracts with
animal-sniffer
* Perhaps the JRE runtime signatures need to be "modularized" so that
rather than being a single artifact they are a tree of artifacts
reflecting
the inter-module dependencies
If we want a Java9 signature, it will probably be a bundle of signatures
(one per module) in one artifact. I don't think we should ask developers
to add every module-signature to the sniffer, Maven should be able to
select to proper signatures from that bundle.
And we probably need to only have signatures for the *accessible* methods.
Robert
I had a feeling going through the talk that there was another point I
wanted to respond to... but I can only recall those two
-Stephen
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
