Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/127#discussion_r82700832
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
---
@@ -76,7 +76,7 @@ public TestSetRunListener( ConsoleReporter
consoleReporter, FileReporter fileRep
StatisticsReporter statisticsReporter,
boolean trimStackTrace,
boolean isPlainFormat, boolean
briefOrPlainFormat )
{
- this.consoleReporter = consoleReporter;
+ this.consoleReporter = consoleReporter != null ? consoleReporter :
new NullConsoleReporter();
--- End diff --
@britter
>>does this belong into DefaultReporterFactory.createReporter()
If you mean this code:
`ConsoleReporter consoleReporter = shouldReportToConsole() ? new
ConsoleReporter( consoleLogger ) : null;`
Then I would keep the responsibility of creating anew reporter yet in the
method `createReporter()`. I am going to fix a bug exactly in this part of code
after you. We can still improve the code by small incremental changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
