A little bit off-topic:
the package + newlines are part of the license. That's not exactly correct.
For the module-info(java9) you want to specify the license (and check for it), but it doesn't have a package. Better to split this up in 2 rules: license and package-declaration (module-info excluded)


Robert

On Mon, 17 Oct 2016 23:46:51 +0200, Michael Osipov <micha...@apache.org> wrote:

Am 2016-10-17 um 22:16 schrieb Hervé BOUTEMY:
Le lundi 17 octobre 2016 21:41:07 Michael Osipov a écrit :
Am 2016-10-17 um 21:27 schrieb Hervé BOUTEMY:
just for the records: does not fix any errors reported by Checkstyle

"// CHECKSTYLE_OFF: RegexpHeader" remains in the files to ignore the
standard header check (that cannot be applied to package-info.java)

Do you still have errors?
I did not have errors before, and don't have after: that's the role of the
CHECKSTYLE_OFF: RegexpHeader

I was not able to deploy since checkstyle
complained about them. Aligned the style to the rest of our source made
it magically work.
strange, since even with your change, the style is not compliant: the first
line should start with "package"

can you share the error you get?


$ git branch
* (HEAD detached at 0dc0cca)

$ mvn deploy
...
[INFO]
[INFO] --- maven-jar-plugin:3.0.0:jar (default-jar) @ maven-resolver-api --- [INFO] Building jar: D:\Entwicklung\Projekte\maven-resolver\maven-resolver-api\target\maven-resolver-api-1.2.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-site-plugin:3.5.1:attach-descriptor (attach-descriptor) @ maven-resolver-api ---
[INFO]
[INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @ maven-resolver-api --- [INFO] There are 77 errors reported by Checkstyle 6.1.1 with config/maven_checks.xml ruleset. [ERROR] src\main\java\org\eclipse\aether\artifact\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\collection\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\deployment\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\graph\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\installation\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\metadata\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\repository\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\resolution\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\transfer\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '. [ERROR] src\main\java\org\eclipse\aether\version\package-info.java[1] (header) RegexpHeader: Zeile entspricht nicht der erwarteten Header-Zeile '^package '.
[INFO] Ignored 66 errors, 11 violations remaining.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Maven Artifact Resolver ............................ SUCCESS [ 32.965 s] [INFO] Maven Artifact Resolver API ........................ FAILURE [ 3.829 s]
[INFO] Maven Artifact Resolver SPI ........................ SKIPPED
[INFO] Maven Artifact Resolver Test Utilities ............. SKIPPED
[INFO] Maven Artifact Resolver Utilities .................. SKIPPED
[INFO] Maven Artifact Resolver Implementation ............. SKIPPED
[INFO] Maven Artifact Resolver Connector Basic ............ SKIPPED
[INFO] Maven Artifact Resolver Transport Classpath ........ SKIPPED
[INFO] Maven Artifact Resolver Transport File ............. SKIPPED
[INFO] Maven Artifact Resolver Transport HTTP ............. SKIPPED
[INFO] Maven Artifact Resolver Transport Wagon ............ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36.998 s
[INFO] Finished at: 2016-10-17T23:44:10+02:00
[INFO] Final Memory: 36M/494M
[INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.15:check (checkstyle-check) on project maven-resolver-api: You have 11 Checkstyle violations. -> [Help 1]
[ERROR]





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to