GitHub user britter opened a pull request:

    https://github.com/apache/maven-surefire/pull/133

    SUREFIRE-1307: Provide a convenient way to run tests against multiple JUnit 
versions

    First proposal to run tests against multiple JUnit versions.
    
    I implemented an Enum representing the available JUnit versions. The Enum 
values know how to configure the maven launcher in order to execute tests with 
that JUnit version. For all 4.x versions this is simply done by setting the 
junit.version system property. For JUnit 5 and the JUnit 5 vintage support, a 
profile needs to be activated.
    
    If this i going into the right direction, we can create a parent pom file 
with the profiles and adopt this to more of the existing tests.
    
    Feedback weclome @Tibor17 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/britter/maven-surefire SUREFIRE-1307

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #133
    
----
commit 3eb690395d05484ffdb76148e8bbc7aea2071ea3
Author: Benedikt Ritter <[email protected]>
Date:   2016-09-06T20:29:10Z

    Add basic integration test for JUnit 5

commit 6dba432eb27d525b300775a55d4c6108385870dd
Author: Benedikt Ritter <[email protected]>
Date:   2016-09-07T19:05:51Z

    Remove redundant variable initialization

commit 0fabae980495b7e9c175de2d6cab7cd8e26f705a
Author: Benedikt Ritter <[email protected]>
Date:   2016-09-07T19:06:52Z

    Remove trailing whitespaces

commit fd1e743f8de3ea8e40189f4c978843dcfe8b146b
Author: Benedikt Ritter <[email protected]>
Date:   2016-09-07T19:17:44Z

    Remove senseless variable assignments

commit 13a2ae14ed18ba2d3207051dec0c7a8cafa231dd
Author: Benedikt Ritter <[email protected]>
Date:   2016-09-07T19:19:21Z

    Make sure tearDown is called

commit 35a06512f382b716b8257111485f345114de8493
Author: Benedikt Ritter <[email protected]>
Date:   2016-09-07T19:22:22Z

    Don't use static import

commit e61a0561b05784e443d0d3e4a0fa261ca24e161a
Author: Benedikt Ritter <[email protected]>
Date:   2016-09-14T15:37:56Z

    Correct assertion of executed test number

commit 8eae2878cba9760f33c3d5a69fcd693be3d11b67
Author: Benedikt Ritter <[email protected]>
Date:   2016-09-19T06:37:38Z

    Make sure JUnit 5 IT only runs on Java 8

commit da928141270c2e8bcad9999f7dcdf24ec80ec357
Author: Benedikt Ritter <[email protected]>
Date:   2016-10-13T19:12:42Z

    Merge branch 'master' into merge-with-master

commit 108538bae9fd5957aea47135f232ac2529167ff8
Author: Benedikt Ritter <[email protected]>
Date:   2016-10-09T12:30:49Z

    Remove unused property

commit 8995a2894488d6ca3796f274498b1516cd2ed131
Author: Benedikt Ritter <[email protected]>
Date:   2016-10-09T12:43:20Z

    Reuse Junit4VersionsIT to also test JUnit 5

commit 1ab033afb89c1646c64e4b95ed184179c1670c62
Author: Benedikt Ritter <[email protected]>
Date:   2016-10-09T12:51:55Z

    Add test using vintage engine

commit 81f3dda52af9805a46bab2e608c62ed1b0e6b9fd
Author: Benedikt Ritter <[email protected]>
Date:   2016-10-09T13:32:10Z

    Move share compiler configuration among projects

commit a50c823baba16f0bc5e4b7c08993d1bf706ce1dc
Author: Benedikt Ritter <[email protected]>
Date:   2016-10-10T17:04:24Z

    Sure one test among JUnit 4 and JUnit 5

commit 31b55924060c9b8994a28761c8d8722a6f1d491c
Author: Benedikt Ritter <[email protected]>
Date:   2016-10-10T17:27:26Z

    Introduce JUnitVersion enum for configuring tests for different junit 
versions

commit e4a5247a74ad95d4b79c074402c959414dfa2732
Author: Benedikt Ritter <[email protected]>
Date:   2016-11-22T20:16:37Z

    Move engines into plugin declaration

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to