Hello, Christian Schulte <c...@schulte.it> schrieb am Di., 3. Jan. 2017 um 02:57 Uhr:
> Am 01/02/17 um 21:01 schrieb Benson Margulies: > > On Mon, Jan 2, 2017 at 1:38 PM, Hervé BOUTEMY <herve.bout...@free.fr> > wrote: > > > >> Christian, > >> > >> Please read Tibor's concerns: > >> - big change, > >> - near release (with parallel branches for JUnit 5) > >> And I'll add: noise, like addition of final, reordering of imports, > >> addition/ > >> suppression of empty lines > >> > >> Please follow Tibor's request, which tries to be as kind as possible: > >>> So now please revert last change [1] and let's start from the ground. > >>> We should again learn from the beginning and start communicating in the > >>> community; otherwise this is the end of the project. > >> > > > > In my uninteresting opinion, Tibor should formally veto the commit. > That's > > not un-nice, it's the way to express, clearly and crisply, his view that > > the change is not acceptable without further discussion and refinement. > On > > the other hand, I don't think that the remarks about 'playgrounds' or > > 'sandboxes' are appropriate or respectful. We should all assume good > intent > > and professional intent. We are running a CTR system here, and so we > should > > expect something like this to happen from time to time, where someone > > commits with the best of intentions and someone else feels strongly that > > more work is needed. > > > > Once Tibor has vetoed, Christian should revert, and then the process > should > > unfold from there. > > > > This part of the commit does not correct any exception suppressed > incorrectly, it really fixes a resource leak (lacking calls to close). > I think everybody should calm down for a moment and remember that we're all just trying to create some great software here :-) At the commons project we usually inform the mailing list when we start to work on components we don't work on a regular basis. Maybe this is the kind of transparency Tibor was asking about. I understand Tibor's point about the surefire codebase. I suspect he feels pretty much left alone. This is what I observed when I was working on the JUnit 5 integration. On the other hand I understand Christians motivation to try to make things better. Regards, Benedikt > > < > https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commitdiff;h=e5a6b9c8d4f514100a01dea2acf1fb059e294968#patch11 > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
