Am 01/10/17 um 00:40 schrieb Stephen Connolly:
> It seems you are modifying an existing test:
> https://github.com/apache/maven-integration-testing/blob/8852538208e508fdc7b58d6332ca683bfc0c9373/core-it-support/core-it-plugins/mng5805-extension/src/main/resources/META-INF/plexus/components.xml
> 
> Integration tests should be append-only (with rare exceptions)
> 
> If the resource needs to be changed then mark the test with an upper range
> limit of ,3.5.0) and create the new test with a range limit of [3.5.0,
> 
> Changing existing tests is bad and was one of the reasons why we had to
> reset
> 
> -1 on the current formulation of this change.

I am only the committer. I'll try to bring the authors of the commits
into the discussion.

Issue: <https://issues.apache.org/jira/browse/MNG-5958>.

Commit in the core:
<https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=71ada08978c78d3b1416f0cf4f63942dddb171d9>

author  Stuart McCulloch <mccu...@gmail.com>    
        Wed, 6 Jan 2016 12:23:06 +0100 (11:23 +0000)

Commit to the ITs:
<https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=8852538208e508fdc7b58d6332ca683bfc0c9373>

author  Anton Tanasenko <atg.sleepl...@gmail.com>       
        Thu, 7 Jan 2016 03:01:28 +0100 (04:01 +0200)

Issue introducing the IT which needs to be changed:
<https://issues.apache.org/jira/browse/MNG-5805>

Commits to the core:
<https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=3677220f6e499e97f2b47b0593bc394b689d14d6>

author  Anton Tanasenko <atg.sleepl...@gmail.com>       
        Sun, 19 Jul 2015 22:01:50 +0100 (00:01 +0300)

<https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=9f7971dadbec8882b4c119345494b620d3a1f897>

author  Anton Tanasenko <atg.sleepl...@gmail.com>       
        Sat, 1 Aug 2015 15:02:52 +0100 (17:02 +0300)

Commits to the ITs due to this:
<https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=63656ffd5cd9c5287715336a5f91baf27c8360f1>

author  Anton Tanasenko <atg.sleepl...@gmail.com>       
        Sun, 19 Apr 2015 22:50:37 +0100 (00:50 +0300)

<https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=ef7b0d378305ab62aa7b3824b808588e5cb1a11e>

author  Anton Tanasenko <atg.sleepl...@gmail.com>       
        Mon, 27 Apr 2015 22:58:32 +0100 (00:58 +0300)

The author of the IT being changed appears to be the same author who
contributed the initial version.

+1 from me (committer) for the change.

Regards,
-- 
Christian


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to