See my comments below.
Am 24.01.2017 um 20:33 schrieb [email protected]:
> Repository: maven
> Updated Branches:
> refs/heads/MNG-5993 [created] be21b5f56
>
>
> [MNG-5993] Confusing error message in case of missing/empty
> artifactId/groupId and version in pluginManagement
>
>
> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/be21b5f5
> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/be21b5f5
> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/be21b5f5
>
> Branch: refs/heads/MNG-5993
> Commit: be21b5f5670a5369495cf21237db5eda5c9cc446
> Parents: bc07e74
> Author: Karl Heinz Marbaise <[email protected]>
> Authored: Fri Apr 1 22:53:37 2016 +0200
> Committer: Karl Heinz Marbaise <[email protected]>
> Committed: Tue Jan 24 20:32:46 2017 +0100
>
> ----------------------------------------------------------------------
> .../internal/LifecyclePluginResolver.java | 12 +-
> .../internal/DefaultPluginVersionResolver.java | 8 +-
> .../model/validation/DefaultModelValidator.java | 170 +++++++++++--------
> .../validation/DefaultModelValidatorTest.java | 73 ++++++--
> .../missing-artifactId-pluginManagement.xml | 39 +++++
> .../raw-model/missing-ga-pluginManagement.xml | 39 +++++
> .../missing-groupId-pluginManagement.xml | 39 +++++
> .../missing-plugin-version-pluginManagement.xml | 40 +++++
> 8 files changed, 323 insertions(+), 97 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/be21b5f5/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecyclePluginResolver.java
> ----------------------------------------------------------------------
> diff --git
> a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecyclePluginResolver.java
>
> b/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecyclePluginResolver.java
> index 956e717..f02552a 100644
> ---
> a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecyclePluginResolver.java
> +++
> b/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecyclePluginResolver.java
> @@ -19,6 +19,9 @@ package org.apache.maven.lifecycle.internal;
> * under the License.
> */
>
> +import java.util.HashMap;
> +import java.util.Map;
> +
> import org.apache.maven.execution.MavenSession;
> import org.apache.maven.model.Plugin;
> import org.apache.maven.model.PluginManagement;
> @@ -30,9 +33,6 @@ import org.apache.maven.project.MavenProject;
> import org.codehaus.plexus.component.annotations.Component;
> import org.codehaus.plexus.component.annotations.Requirement;
>
> -import java.util.HashMap;
> -import java.util.Map;
> -
> /**
> * @since 3.0
> * @author Benjamin Bentmann
> @@ -46,7 +46,6 @@ public class LifecyclePluginResolver
> @Requirement
> private PluginVersionResolver pluginVersionResolver;
>
> -
> public LifecyclePluginResolver( PluginVersionResolver
> pluginVersionResolver )
> {
> this.pluginVersionResolver = pluginVersionResolver;
> @@ -65,9 +64,8 @@ public class LifecyclePluginResolver
> {
> if ( plugin.getVersion() == null )
> {
> - PluginVersionRequest request =
> - new DefaultPluginVersionRequest( plugin,
> session.getRepositorySession(),
> -
> project.getRemotePluginRepositories() );
> + PluginVersionRequest request = new
> DefaultPluginVersionRequest( plugin, session.getRepositorySession(),
> +
> project.getRemotePluginRepositories() );
> plugin.setVersion( pluginVersionResolver.resolve( request
> ).getVersion() );
> }
> versions.put( plugin.getKey(), plugin.getVersion() );
>
> http://git-wip-us.apache.org/repos/asf/maven/blob/be21b5f5/maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java
> ----------------------------------------------------------------------
> diff --git
> a/maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java
>
> b/maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java
> index f11ee95..2275b7a 100644
> ---
> a/maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java
> +++
> b/maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java
> @@ -87,8 +87,6 @@ public class DefaultPluginVersionResolver
> public PluginVersionResult resolve( PluginVersionRequest request )
> throws PluginVersionResolutionException
> {
> - logger.debug( "Resolving plugin version for " + request.getGroupId()
> + ":" + request.getArtifactId() );
> -
> PluginVersionResult result = resolveFromProject( request );
>
> if ( result == null )
> @@ -103,8 +101,8 @@ public class DefaultPluginVersionResolver
> }
> else if ( logger.isDebugEnabled() )
> {
> - logger.debug( "Resolved plugin version for " +
> request.getGroupId() + ":" + request.getArtifactId()
> - + " to " + result.getVersion() + " from POM " +
> request.getPom() );
> + logger.debug( "Resolved plugin version for " +
> request.getGroupId() + ":" + request.getArtifactId() + " to "
> + + result.getVersion() + " from POM " + request.getPom() );
> }
>
> return result;
> @@ -156,6 +154,7 @@ public class DefaultPluginVersionResolver
> String version = null;
> ArtifactRepository repo = null;
>
> + logger.info( "selectVersion:" + request.getGroupId() );
Can this log level be decreased to debug, please.
> if ( StringUtils.isNotEmpty( versions.releaseVersion ) )
> {
> version = versions.releaseVersion;
> @@ -351,6 +350,7 @@ public class DefaultPluginVersionResolver
> {
> PluginVersionResult result = null;
>
> + logger.info( "resolveFromProject:" + request.getGroupId() );
Same here. I've seen those messages with 3.4.0-SNAPSHOT and never got
the meaning of them.
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
