Github user stephenc commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/144#discussion_r103110391
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/ConsoleOutputFileReporter.java
---
@@ -69,8 +69,8 @@ public void close()
{
try
{
- fileOutputStream.flush();
- fileOutputStream.close();
+ // fileOutputStream.flush(); Will not call close on
exception!
+ fileOutputStream.close(); // Will implicitly flush.
--- End diff --
Then the correct way to do that is wrap the flush in another layer of try
catch (and leave a todo to use addSuppressed once baseline JVM for the code is
Java 7)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
