Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/143#discussion_r108780826
  
    --- Diff: 
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java
 ---
    @@ -196,7 +196,8 @@ else if ( "failure".equals( qName ) )
                     }
                     else if ( "error".equals( qName ) )
                     {
    -                    testCase.setFailure( attributes.getValue( "message" ), 
attributes.getValue( "type" ) );
    +                    testCase.setFailure( attributes.getValue( "message" ), 
attributes.getValue( "type" ) )
    --- End diff --
    
    If having an error, then failure and error are set both. Why?
    See Line 235. Maybe you should introduce `setErrorDetail` similar to what 
is `setFailureDetail`, and show the detail in HTML report and thus distinguish 
between these two.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to