Github user ifedorenko commented on the issue:
https://github.com/apache/maven/pull/69
I still vote -1 on this change.
While I appreciate "dependency reduced pom" usecase, I'd like the following
two concerns addressed first:
* Mutated pom.xml files must not invalidate original reactor
ProjectDependencyGraph. More specifically, if the original graph allowed
certain build order, the new graph must still allow the same order. In practice
this means the new graph must not have any new dependencies, which is rather
tricky to guarantee when we consider dependency `<excludes>` and dependency
management.
* Implementation must scale well to 5K+ modules and 5K managed external
dependencies. In practice this requires some sort of caching to avoid repeated
reparsing/reinterpollation of reactor pom.xml files.
Additionally, I'd like to understand expected behaviour when projects with
dependency reduced pom files are excluded from the build using `--projects`
command line argument or pom-reducing mojo is not part of selected build phase.
I have not analyzed this in details, but I believe mutable pom.xml files can
lead to odd/unexpected build results that will be difficult to explain and
hence require extra support effort (I happen to help maintain builds for a
reasonably large developer community, so supportability is an important concern
for me).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
