Github user dejan2609 commented on the issue:

    https://github.com/apache/maven/pull/119
  
    
    
    New changes are pushed via new commit (all commits will be squashed into 
one eventually). 
    Solution is tested across different Maven versions (**3.0.5**, **3.1.1**, 
**3.2.5**, **3.3.9** and **3.5.0**).
    
    Test renaming is recalled; however, it seems kind of reasonable (necessary 
?) to fine-grain those test cases instead of adding a new one.
    **Rationale:** since both existing test cases already consume pom.xml files 
with mutually dependent tags:
    >  \<scope>_**system**_\</scope>
    >  \<systemPath>_**Some_Path**_\</systemPath>
    
    it seems convenient to carefully reuse those existing test cases, because 
both tags end up tested anyway (I reckon that adding a new test case with same 
two tags would be redundant). 
    
    @khmarbaise: let me know what you think (and please forgive me if my 
rationale is not that rational, I'll be ready to dig deeper and accommodate 
solution in order to fit standards).
    
    Bonus question (in the unlikely case that I got it all right): does it make 
sense to introduce new  **ModelBuildingRequest** **_VALIDATION_LEVEL_MAVEN_** 
(_**3_5**_ or _**3_6**_) ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to