Hi,
Nice catch, stupid me... how did we not catch it during review?
Let's be pragmatic: I fixed this stupid issue directly to master
> I wonder if it's feasible to add an integration test that checks
> that Maven home is the same before and after some build.
if you have an idea of an IT, don't hesitate to propose one.
The auto-extracted native should be deleted after Maven execution, then it's
not IMHO obvious to check that it has been created during the run
Regards,
Hervé
Le samedi 10 juin 2017, 00:06:35 CEST Guillaume Boué a écrit :
> Hi,
>
> The current mvn startup script sets the "library.jansi.path" system
> property to "${MAVEN_HOME}/jansi-native". But instead, as said in
> MNG-6186, this should be "${MAVEN_HOME}/lib/jansi-native". This also
> affects the Windows script. The result is that JAnsi is creating a
> jansi-native directory in Maven home and adding new so/dll files in it
> for every mvn invocation. 3.5.0 is correct, this is a small in-version
> regression.
>
> Should this fix be committed to a new branch, or maybe directly to
> master? I wonder if it's feasible to add an integration test that checks
> that Maven home is the same before and after some build.
>
> Thanks,
> Guillaume
>
> ---
> L'absence de virus dans ce courrier électronique a été vérifiée par le
> logiciel antivirus Avast. https://www.avast.com/antivirus
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
