Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/150#discussion_r136932487
  
    --- Diff: 
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/MatchMethodDescriptions.java
 ---
    @@ -0,0 +1,74 @@
    +package org.apache.maven.surefire.common.junit48;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +import org.junit.runner.Description;
    +import org.junit.runner.manipulation.Filter;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +/**
    + * Only run test methods in the given failure set
    + *
    + * @author mpkorstanje
    + */
    +final class MatchMethodDescriptions
    +    extends Filter
    +{
    +
    +    private final List<Filter> filters = new ArrayList<Filter>();
    +
    +    MatchMethodDescriptions( Iterable<Description> descriptions )
    +    {
    +        for ( Description description : descriptions )
    +        {
    +            filters.add( matchMethodDescription ( description ) );
    +        }
    +    }
    +
    +    @Override
    +    public boolean shouldRun( Description description )
    +    {
    +        for ( Filter filter : filters )
    --- End diff --
    
    This loop is different from the deleted class but I need to have spare time 
to have deep looking.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to