I'm going to hold off closing the vote over the weekend to give Igor a chance to:
1. comment on whether we need an alternative fix for MNG-6275 (and indeed ideally provide one ;- ); 2. comment on whether the fix for MNG-6209 is exposing bugs in plugins that made incorrect assumptions about TCCL, or whether the fix is invalid or even incomplete (I wonder if TCCL should always be project.getClassRealm() as extensions should be available to all plugins not just those that declare they are providing extensions - unless I misunderstand) Once I have the required information I will be better able to assess whether we should release 3.5.1 and follow up with a quick 3.5.2 or just drop 3.5.1 and go straight to 3.5.2. -Stephen On 15 September 2017 at 05:45, Igor Fedorenko <i...@ifedorenko.com> wrote: > Has anyone tried wiring jvm extensions ClassLoader as foreign import to > plugin/extensions realms? Jvm extensions classloader is little tricky to > get to (see how this is done in java.util.ServiceLoader.loadInstalled), > but I think this will solve ServiceLoader/MNG-6275 without polluting > plugin classpath too much. > > -- > Regards, > Igor > > On Fri, Sep 15, 2017, at 08:32 AM, Mark Derricutt wrote: > > Would it be possible to handle this in a somewhat similar way to > > threadSafe > > mojos - some form of plugin flag that says "extensionSafe" [1], that if > > the > > plugin has <extensions>true</extensions> declared and doesn't declare > > itself as being extensionSafe/extensionAware then we log a build warning > > - > > it wouldn't solve anything, other than giving some feedback to users some > > indication of WHY their build fails under 3.5.1 - and to either remove > > <extensions> or fix/update their plugins. > > > > [1] Or even just infer the applicability of extensions by the presence of > > custom lifecycles, or Mojos implementing the extension interfaces ( it's > > midnight, and a hazy tired thought ). > > > > -- > > "Great artists are extremely selfish and arrogant things" — Steven > > Wilson, > > Porcupine Tree > > > > On Sat, Sep 16, 2017 at 12:22 AM, Anders Hammar <and...@hammar.net> > > wrote: > > > > > Based on Igor's feedback I'm changing my vote to +1. > > > > > > Having this class loader change in a bug fix release is probably not > > > (semver) ideal though. > > > > > > /Anders > > > > > > On Fri, Sep 15, 2017 at 2:12 PM, Igor Fedorenko <i...@ifedorenko.com> > > > wrote: > > > > > > > I answered in more details on m2e-dev, but I believe we can > compensate > > > > for the change from m2e end. In the worst case we'll bundle hacked > > > > version of DefaultClassRealmManager with m2e, not ideal, but not the > end > > > > of the world either. > > > > > > > > -- > > > > Regards, > > > > Igor > > > > > > > > On Fri, Sep 15, 2017, at 07:21 AM, Anders Hammar wrote: > > > > > On Fri, Sep 15, 2017 at 8:29 AM, Anders Hammar <and...@hammar.net> > > > > wrote: > > > > > > > > > > > Reporting back from tests of m2e with embedded Maven 3.5.1, we > see > > > > problem > > > > > > with the jaxws-maven-plugin mojo. We're two people seeing the > issue > > > > > > independently, but unfortunately Fred Bricon hasn't been able to > > > > reproduce. > > > > > > > > > > > > > > > > To follow up on this, my tests indicate that Maven 3.5.1 causes > changed > > > > > class loading that could cause issues for plugins in m2e. I've > asked > > > for > > > > > input from the m2e devs if it is possible to handle in m2e but they > > > > > haven't > > > > > responded yet. > > > > > > > > > > /Anders > > > > > > > > > > > > > > > > > > > > > > So currently I'm 0 on the voting but I'll investigate some more. > > > > > > > > > > > > /Anders > > > > > > > > > > > > On Wed, Sep 13, 2017 at 9:26 AM, Anders Hammar < > and...@hammar.net> > > > > wrote: > > > > > > > > > > > >> > > > > > >> > > > > > >> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly < > > > > > >> stephen.alan.conno...@gmail.com> wrote: > > > > > >> > > > > > >>> Have we got any feedback from the embedder integrations yet? > > > > > >>> > > > > > >> > > > > > >> I haven't heard anything from the m2e people. Maybe we need to > ping > > > > them > > > > > >> directly. I can contact Fred Bricon. > > > > > >> > > > > > >> /Anders > > > > > >> > > > > > >> > > > > > >>> > > > > > >>> On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY < > herve.bout...@free.fr> > > > > > >>> wrote: > > > > > >>> > > > > > >>> > just for the records: it is Windows + Git Bash (MINGW64) only > > > > > >>> > > > > > > >>> > and there is a chance that adding -Djansi.force=true can > force > > > > JAnsi > > > > > >>> > activation (even if JAnsi fails to detect that it should > > > > auto-activate) > > > > > >>> > > > > > > >>> > details on issue in https://issues.apache.org/ > > > jira/browse/MNG-6282 > > > > , > > > > > >>> and a > > > > > >>> > future JAnsi issue... > > > > > >>> > > > > > > >>> > Regards, > > > > > >>> > > > > > > >>> > Hervé > > > > > >>> > > > > > > >>> > Le lundi 11 septembre 2017, 12:53:46 CEST Stephen Connolly a > > > écrit > > > > : > > > > > >>> > > So that is windows only, or were they lost on other OSes > for > > > you. > > > > > >>> > > > > > > > >>> > > I have colours on linux (via docker) and os-x > > > > > >>> > > > > > > > >>> > > On 11 September 2017 at 12:35, dejan2...@gmail.com < > > > > > >>> dejan2...@gmail.com> > > > > > >>> > > > > > > > >>> > > wrote: > > > > > >>> > > > +1 (conditionally). > > > > > >>> > > > > > > > > >>> > > > Tested via project that includes dozen of plugins: 1st > tier, > > > > > >>> MojoHaus > > > > > >>> > and > > > > > >>> > > > few 3rd party plugins (so to say). > > > > > >>> > > > > > > > > >>> > > > Everything looks good with one notable regression: > > > > > >>> > > > https://issues.apache.org/jira/browse/MNG-6282 Console > > > output > > > > has > > > > > >>> no > > > > > >>> > > > colors (regression in Maven 3.5.1) > > > > > >>> > > > > > > > > >>> > > > Regards, > > > > > >>> > > > Dejan > > > > > >>> > > > > > > > > >>> > > > On 2017-09-10 17:39, Stephen Connolly < > > > > > >>> stephen.alan.conno...@gmail.com > > > > > >>> > > > > > > > >>> > > > > > > > > >>> > > > wrote: > > > > > >>> > > > > Hi, > > > > > >>> > > > > > > > > > >>> > > > > We solved 25 issues: > > > > > >>> > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa > ? > > > > > >>> > > > > > > > > >>> > > > version=12338964&styleName=Text&projectId=12316922 > > > > > >>> > > > > > > > > >>> > > > > There are 350 issues left in JIRA for Maven core: > > > > > >>> > > > > https://issues.apache.org/jira/issues/?jql=project%20% > > > > > >>> > > > > > > > > >>> > > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER% > > > > > >>> > > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > > > > >>> > > > > > > > > >>> > > > > Staging repo: > > > > > >>> > > > > https://repository.apache.org/ > content/repositories/maven- > > > > 1364/ > > > > > >>> > > > > > > > > > >>> > > > > The distributable binaries and sources can be found > here: > > > > > >>> > > > > https://repository.apache.org/ > content/repositories/maven-> > > > > > > > > > >>> > > > 1364/org/apache/maven/apache-maven/3.5.1/ > > > > > >>> > > > > > > > > >>> > > > > Specifically the zip, tarball and source archives can > be > > > > found > > > > > >>> here: > > > > > >>> > > > > https://repository.apache.org/ > content/repositories/maven-> > > > > > > > > > >>> > > > 1364/org/apache/maven/apache- > maven/3.5.1/apache-maven-3.5.1- > > > > > >>> bin.zip > > > > > >>> > > > > > > > > >>> > > > > https://repository.apache.org/ > content/repositories/maven-> > > > > > > > > > >>> > > > 1364/org/apache/maven/apache- > maven/3.5.1/apache-maven-3.5.1- > > > > > >>> bin.tar.gz > > > > > >>> > > > > > > > > >>> > > > > https://repository.apache.org/ > content/repositories/maven-> > > > > > > > > > >>> > > > 1364/org/apache/maven/apache- > maven/3.5.1/apache-maven-3.5.1- > > > > > >>> src.zip > > > > > >>> > > > > > > > > >>> > > > > https://repository.apache.org/ > content/repositories/maven-> > > > > > > > > > >>> > > > 1364/org/apache/maven/apache- > maven/3.5.1/apache-maven-3.5.1- > > > > > >>> src.tar.gz > > > > > >>> > > > > > > > > >>> > > > > Source release checksum(s): > > > > > >>> > > > > apache-maven-3.5.1-src.tar.gz sha1: > > > > > >>> 9eb821f153c7667194aa11ccd099b7 > > > > > >>> > > > > > > > > >>> > > > bd2059560d > > > > > >>> > > > > > > > > >>> > > > > apache-maven-3.5.1-src.zip: sha1: > > > > 121d54b045380a8a4895eb137970ab > > > > > >>> > > > > > > > > >>> > > > 69e698eb0e > > > > > >>> > > > > > > > > >>> > > > > Git tag: > > > > > >>> > > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a= > > > > commit;h= > > > > > >>> > > > > > > > > >>> > > > 094e4e31a5af55bb17be87675da41d9aeca062f3 > > > > > >>> > > > > > > > > >>> > > > > Staging site: > > > > > >>> > > > > https://maven.apache.org/components/ref/3-LATEST/ > > > > > >>> > > > > > > > > > >>> > > > > Vote open for 72 hours. > > > > > >>> > > > > > > > > > >>> > > > > [ ] +1 > > > > > >>> > > > > [ ] +0 > > > > > >>> > > > > [ ] -1 > > > > > >>> > > > > > > > > > >>> > > > > Thanks, > > > > > >>> > > > > > > > > > >>> > > > > Stephen. > > > > > >>> > > > > > > > > >>> > > > ------------------------------ > ------------------------------ > > > > > >>> --------- > > > > > >>> > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > >>> > > > For additional commands, e-mail: > dev-h...@maven.apache.org > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> > ------------------------------------------------------------ > > > > --------- > > > > > >>> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > >>> > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >>> > > > > > > >>> > -- > > > > > >>> Sent from my phone > > > > > >>> > > > > > >> > > > > > >> > > > > > > > > > > > > > > ------------------------------------------------------------ > --------- > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
