I would expect the icon on the content that can be changed, not in the navigation bar.
That would probably be the div.bodyColumn or div.section

And maybe we need 2 edit buttons: edit+github and edit+cms_asf.
The first one is for users that waqnt to adjust content via PR.
The other one can be used by us to directly edit the content via cms.apache.org

thanks,
Robert


On Mon, 18 Dec 2017 08:42:28 +0100, Hervé BOUTEMY <[email protected]> wrote:

Hi,

I just managed to add an "edit" button in Maven generated sites, that will
help people find the source of the document.

See an example here (the little icon near the version):
http://maven.apache.org/skins-archives/maven-fluido-skin-LATEST/

I wanted to publish it to Maven site through http://svn.apache.org/r1818489 but buildbot did not catch the SNAPSHOT m-site-p plugin: we'll have to wait
for the release (after Doxia then Doxia Sitetools releases: please vote).

Feedback appreciated on the new icon, its configuration, or any idea that could
improve the feature.
Don't hesitate to propose improvements as html changes: we'll see later how to
get the update in the Velocity template that generated the html...

Regards,

Hervé

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to