+1 :) Le lundi 8 janvier 2018, 20:33:12 CET Robert Scholte a écrit : > Just wondering why not simply excluding INFRA- marked messages? > > On Mon, 08 Jan 2018 20:07:24 +0100, Stephen Connolly > > <stephen.alan.conno...@gmail.com> wrote: > > Did you read the comment directly above: > > > > may end up commenting on other TLPs in some cases but should be very rare > > > > There should be very few cases where a commit to our repo refers to > > another > > TLP’s issues. The most common case will be INFRA > > > > On Mon 8 Jan 2018 at 17:41, Robert Scholte <rfscho...@apache.org> wrote: > >> I hope you're aware that the jiraIssue.startsWith("M") check isn't good > >> enough... > >> > >> > >> https://cwiki.apache.org/confluence/display/MAVEN/Maven+JIRA+issues+overv > >> iew > >> > >> https://issues.apache.org/jira/secure/BrowseProjects.jspa?selectedCategor > >> y=10510 > >> > >> thanks, > >> Robert > >> > >> On Mon, 08 Jan 2018 11:03:30 +0100, <steph...@apache.org> wrote: > >> > This is an automated email from the ASF dual-hosted git repository. > >> > > >> > stephenc pushed a commit to branch master > >> > in repository > >> > >> https://gitbox.apache.org/repos/asf/maven-jenkins-env.git > >> > >> > The following commit(s) were added to refs/heads/master by this push: > >> > new 88aff47 Stop commenting on INFRA tickets > >> > > >> > 88aff47 is described below > >> > > >> > commit 88aff478d3b9c821077ebc4338f5ee90f9c56970 > >> > Author: Stephen Connolly <stephen.alan.conno...@gmail.com> > >> > AuthorDate: Mon Jan 8 10:03:24 2018 +0000 > >> > > >> > Stop commenting on INFRA tickets > >> > > >> > --- > >> > > >> > vars/jenkinsNotify.groovy | 20 +++++++++++++------- > >> > 1 file changed, 13 insertions(+), 7 deletions(-) > >> > > >> > diff --git a/vars/jenkinsNotify.groovy b/vars/jenkinsNotify.groovy > >> > index 99e3ce4..24c34a3 100644 > >> > --- a/vars/jenkinsNotify.groovy > >> > +++ b/vars/jenkinsNotify.groovy > >> > @@ -64,21 +64,27 @@ def call(Map params = [:]) { > >> > > >> > // comment on any jira tickets > >> > > >> > def jiraIssues = null > >> > > >> > + def jiraMavens = [] > >> > > >> > try { > >> > > >> > jiraIssues = jiraIssueSelector(issueSelector: [$class: > >> > 'DefaultIssueSelector']) > >> > > >> > for (def jiraIssue in jiraIssues) { > >> > > >> > - try { > >> > - jiraComment body: > >> > "${messageSubject}\n\n${messageBody}", issueKey: jiraIssue > >> > - } catch (e) { > >> > - echo "WARNING: Could not update ${jiraIssue}: > >> > ${e.message}" > >> > - } > >> > + // only comment on maven's issues, all our trackers start > >> > with M > >> > + // may end up commenting on other TLPs in some cases but > >> > should be very rare > >> > + if (jiraIssue.startsWith("M")) { > >> > + try { > >> > + jiraComment body: > >> > "${messageSubject}\n\n${messageBody}", issueKey: jiraIssue > >> > + } catch (e) { > >> > + echo "WARNING: Could not update ${jiraIssue}: > >> > ${e.message}" > >> > + } > >> > + jiraMavens += jiraIssue > >> > + } > >> > > >> > } > >> > > >> > } catch (e) { > >> > > >> > echo "WARNING: Could not determine JIRA issues: ${e.message}" > >> > > >> > } > >> > // set the build description to the jira ticket id's > >> > > >> > - if (jiraIssues != null && !jiraIssues.empty) { > >> > - currentBuild.description = "${jiraIssues.join(', ')}" > >> > + if (!jiraMavens.empty) { > >> > + currentBuild.description = "${jiraMavens.join(', ')}" > >> > > >> > } > >> > > >> > // add the changes to the email > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > >> -- > > > > Sent from my phone > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org