GitHub user clarkperkins opened a pull request:
https://github.com/apache/maven/pull/159
Bugfix/mng 4347 recursive imports
â¦resolved using profile modifications from settings.xml
o Updated the 'DefaultModelResolver' to handle replacing repositories the
same way the
'DefaultDependencyCollector' does. When the 'DefaultDependencyCollector'
finds
a repository in a child node with an id matching a repository already in
use,
it will only merge any mirror definitions but never change the repository
already
in use. The 'DefaultModelResolver' needs to follow the same logic. What
has been
provided must not change for consistency.
Cherry-picked from @ChristianSchulte's fork, per comment on the MNG-4347
ticket. I made the same changes to the ProjectModelResolver, since it seems
that's the implementation that's getting used by the dependencyManagement
import resolution rather than the DefaultModelResolver.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clarkperkins/maven
bugfix/MNG-4347-recursive-imports
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
----
commit c1f3bee77783a1f3349083e431dd4bb7cd7f290a
Author: Christian Schulte <schulte@...>
Date: 2016-12-13T02:30:32Z
[MNG-4347] import-scoped dependencies of direct dependencies are not
resolved using profile modifications from settings.xml
o Updated the 'DefaultModelResolver' to handle replacing repositories the
same way the
'DefaultDependencyCollector' does. When the 'DefaultDependencyCollector'
finds
a repository in a child node with an id matching a repository already in
use,
it will only merge any mirror definitions but never change the repository
already
in use. The 'DefaultModelResolver' needs to follow the same logic. What
has been
provided must not change for consistency.
commit f8ab4e1e37479d353fd4a6d20442aa29c6ad8899
Author: Clark Perkins <clark.perkins@...>
Date: 2018-02-16T17:59:07Z
Made the same changes to ProjectModelResolver
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
