Hi Olivier, Please make additional testing on Monday. If you find an urgent bug we can always restart the Vote. I hope it will be just fine and we will finish our release before the Java 10 release.
Cheers Tibor On Sun, Feb 18, 2018 at 1:25 AM, Tibor Digana <[email protected]> wrote: > Olivier, your javac settings is ok but it would be more useful in Surefire > 3.0.0. Don't worry, we will not loose your code. I assigned your JIRA issue > to 3.0 first release candidate. > The reason behind is the fact that it is not good for users for change > prerequisite for the plugin too often. > Second reason is that the JDK 10 issues were fixed before but you have > noticed issues in our tests and I fixed this without forcing our Users to > change CI setup in their organizations and thus may stay with Java 6 as > before. > In Version 3.0.0 we would need to have javac 1.7 for our internal needs > anyway. > > My plan after this release would be to proceed fast with JUnit5 Provider > and 3.0 API + Java 7. > We already have two branches for both. So this process will be very fast > and there is no reason to wait. Then we can push bug fixing in 3.0 RC2, > pull requests from GitHub etc. > > > On Sat, Feb 17, 2018 at 1:05 PM, Tibor Digana <[email protected]> > wrote: > >> Ok, we can make additional testing by then. >> I have another question to our shared Groovy library [1]. I am missing >> configuration with Maven 3.1.x. Is there any problem with this version why >> we did not add it? Our Surefire build works fine with Maven 3.1.1 but of >> course I tested this combination on my local PC. >> >> [1]: https://gitbox.apache.org/repos/asf?p=maven-jenkins-env.git; >> a=blob;f=vars/jenkinsEnv.groovy;h=9b19ae382c4aff972779f6e1e5 >> 97c26137fca7cf;hb=HEAD >> >> >> >> On Sat, Feb 17, 2018 at 12:51 PM, Olivier Lamy <[email protected]> wrote: >> >>> maybe give a bit of time to test master branch >>> I should be able to do some testing by monday >>> >>> On 17 February 2018 at 21:50, Tibor Digana <[email protected]> >>> wrote: >>> >>> > I do not see any issues with the Jenkins run at the moment. >>> > Most probably the build would be successful. >>> > The build should finish around 11pm today. Then I would like to merge >>> the >>> > branch to master and start the release vote right after. The >>> distribution >>> > artifacts would be already deployed in Maven Central after the Vote, >>> means >>> > Wednesday morning, the 21st of Feb. The first release candidate of JDK >>> 10 >>> > will be our on Thursday, 22nd of Feb. >>> > Oki? >>> > >>> > On Sat, Feb 17, 2018 at 12:32 PM, Olivier Lamy <[email protected]> >>> wrote: >>> > >>> > > On 17 February 2018 at 19:44, Tibor Digana <[email protected]> >>> > wrote: >>> > > >>> > > > I am currently running the CI job #129 of Surefire with JDK 7, 8, >>> 9, >>> > 10, >>> > > > Maven 3.2, 3.3, 3.5, Linux and Windows: >>> > > > This is the link to pipeline >>> > > > https://builds.apache.org/job/maven-wip/job/maven-surefire/ >>> > > > job/SUREFIRE-1463/ >>> > > > >>> > > > The old job #128 passed the most of the Linux builds. >>> > > > My last push -f crashed git checkout in the Pipeline. Bad luck, I >>> just >>> > > > forced changes on the git HEAD of the branch meanwhile the >>> checkout was >>> > > > running and the command 'git checkout' just crashed in Jenkins. >>> > > > I have Windows 7 and the native library used in test >>> > > > Surefire1295AttributeJvmCrashesToTestsIT is working as expected >>> but >>> > our >>> > > > Jenkins in ASF is using Windows NT and there the library used in >>> the IT >>> > > > does not work properly. I already reported an issue in the open >>> source: >>> > > > https://github.com/michaeltandy/crashjvm/issues/1 >>> > > > >>> > > > Cheers >>> > > > Tibor >>> > > > >>> > > > >>> > > TBH I would prefer disable this test for windauze if it prevent >>> moving >>> > > forward (I'm not if Windows NT is a really important issue :-) ) >>> > > so if you're happy merge to master. >>> > > too long time we didn't push any release. >>> > > >>> > > >>> > > >>> > > > >>> > > > >>> > > > >>> > > > >>> > > > On Fri, Feb 16, 2018 at 3:52 PM, Tibor Digana < >>> [email protected]> >>> > > > wrote: >>> > > > >>> > > > > The reason why I was idle is the fact I made everyting to to >>> support >>> > > > > Surefire on Jdk 7-10 & Maven 3.1 - 3.5 and Linux/Windows and I >>> am now >>> > > > happy >>> > > > > with that. I did not commit it in my branch yet. >>> > > > > I don't want to loose all my work, therefore the branch >>> > *SUREFIRE-1463* >>> > > > > will be finalized by today evening and then I will wait for >>> Jenkins >>> > > > result >>> > > > > but my local build worked with many configurations so far. >>> > > > > I have made a quite a lot of improvements connected to broken >>> tests >>> > > > > regarding the combination of Maven & Jdk & Platform version and I >>> > > really >>> > > > do >>> > > > > not want to loose all of that. >>> > > > > And the best is that I did not use latest *commons-lang3* in >>> > > > > *src/main/java*, but I used that in *src/test/java*. This means >>> I do >>> > > not >>> > > > > have to force the Users to adapt to *JDK7*. This should be the >>> plan >>> > in >>> > > > > version *3.0.0*. >>> > > > > So today I will finish *Jenkinsfile*, the jobs will run in a >>> sequence >>> > > as >>> > > > > a preference. >>> > > > > If you saw my e-mails you would notice that I also had a problem >>> with >>> > > > > Jenkins because Jenkins started a lot of parallel runs in >>> *ubuntu-1* >>> > > > > however it has only 2 executors - I expected only two runs but >>> there >>> > > was >>> > > > > much more and overloaded. >>> > > > > Why *ubuntu-1*? The answer is the large number of ITs we have. >>> We >>> > have >>> > > > > also sophisticated tests with native libraries and these did not >>> work >>> > > in >>> > > > > every ASF machine. >>> > > > > I have very good results with *java.sql.Date*. I saw it but it's >>> > gone. >>> > > > > >>> > > > > >>> > > > > On Fri, Feb 16, 2018 at 1:42 PM, Robert Scholte < >>> > [email protected]> >>> > > > > wrote: >>> > > > > >>> > > > >> And this is not an issue with Java 9? >>> > > > >> >>> > > > >> It might be related to MNG-6275[1]. Classworlds seems to use the >>> > > > >> bootclassloader, which doesn't expose all the jdk/jre classes >>> like >>> > > > >> java.sql.Date. >>> > > > >> We weren't able to fix this in 3.5.x >>> > > > >> >>> > > > >> Robert >>> > > > >> >>> > > > >> [1] https://issues.apache.org/jira/browse/MNG-6275 >>> > > > >> >>> > > > >> On Fri, 16 Feb 2018 12:16:59 +0100, Olivier Lamy < >>> [email protected]> >>> > > > >> wrote: >>> > > > >> >>> > > > >> Hi, >>> > > > >>> I'm currently testing maven builds with jdk10 (especially >>> surefire) >>> > > > >>> I noticed velocity tools need java.sql.Date (yes it is :-) ) >>> > > > >>> See stack trace: >>> > > > >>> https://gist.github.com/olamy/243bf93f77becdd698148b07065b84f7 >>> > > > >>> >>> > > > >>> Well ATM I'm not sure how to fix that... >>> > > > >>> >>> > > > >>> Cheers >>> > > > >>> >>> > > > >> >>> > > > >> ------------------------------------------------------------ >>> > --------- >>> > > > >> To unsubscribe, e-mail: [email protected] >>> > > > >> For additional commands, e-mail: [email protected] >>> > > > >> >>> > > > >> >>> > > > > >>> > > > >>> > > >>> > > >>> > > >>> > > -- >>> > > Olivier Lamy >>> > > http://twitter.com/olamy | http://linkedin.com/in/olamy >>> > > >>> > >>> >>> >>> >>> -- >>> Olivier Lamy >>> http://twitter.com/olamy | http://linkedin.com/in/olamy >>> >> >> >
