Hi Robert!

Would you mind if we continue the review on MJAVADOC-444?

Per the guidance on that page you mentioned, I'd like to avoid sending multiple 
messages here and I have questions about the need and form for tests in this 
specific case. If you don't mind, I'd quote your response from here on the jira 
and then provide follow up.

One small matter of clarification, I was talking specifically about the JIRA 
project role of contributor (or its equivalent if the Maven project uses some 
bespoke set of jira project configurations). I'm not looking to apply the 
patch, merely place the jira into the common status used to indicate "there's a 
patch here that should be looked at"; often times such status also triggers 
automated testing that's needed prior to formal review. Apologies if the Maven 
project does not use such status or tooling.


On 2018/03/02 15:32:20, "Robert Scholte" <[email protected]> wrote: 
> hi Sean,
> 
> thank you for the patch, which already makes you a contributor.
> To be able to apply patches you need to be a Maven committer.
> If you want to become a committer, please read the Guide Commmitter  
> School[1]
> In case of your patch for MJAVADOC-444, you have to focus on #2 and  
> further.
> 
> thanks,
> Robert
> 
> [1] https://maven.apache.org/guides/development/guide-committer-school
> 
> On Fri, 02 Mar 2018 15:36:15 +0100, Sean Busbey <[email protected]> wrote:
> 
> > Hi!
> >
> > Could someone give me contributor status in jira so I can assign  
> > MJAVADOC-444 to myself and put it in patch available status?
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to