Il sab 27 apr 2019, 13:41 Hervé BOUTEMY <[email protected]> ha scritto:

> Hi,
>
> There are 2 fixes:
> 1. MNG-6636 an issue in Maven model inheritance of input location that
> leads to no input location tracking where it should be inherited
> 2. MNG-6644 and MNG-6647 where some external extensions don't inject input
> location tracking, then reporting has to be tolerant to missing data
>
> See for each the Jira issue, the associated fix and the CI Job:
>
> 1. MNG-6636:
> https://issues.apache.org/jira/browse/MNG-6636
>
> https://gitbox.apache.org/repos/asf?p=maven.git;a=commitdiff;h=dc043c978b48cfe05cd2d5ebd86f8f6c82702f95


Nit: Why are you using Integer.valueOf ?

Would it be useful to add a test?

Maybe for review it is easier to comment on a PR on github for the future


>
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6636/
>
> 2. MNG-6644 and MNG-6647
> https://issues.apache.org/jira/browse/MNG-6644
> https://issues.apache.org/jira/browse/MNG-6647
>
> https://gitbox.apache.org/repos/asf?p=maven.git;a=commitdiff;h=fb8edc076da0a310995866bfa4567e9b15c47bad
>
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6644/


+1

Enrico

>
>
>
> Seconders, please?
>
> Regards,
>
> Hervé
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

Reply via email to