Hi Gabriel,

Let me paraphrase what you said " ... into master ... before I made changes
using PatternExcludesArtifactFilter based on the reviews ".
This means we are missing some commit in master.
In this case it does not make sense to test this project because the work
is incomplete.
We have to complete it first and then restart the release process.
That's better than doing new bug fix(es).

Cheers
Tibor17

On Sun, Aug 25, 2019 at 12:06 AM Gabriel Belingueres <belingue...@gmail.com>
wrote:

> Hi Tibor:
>
> Please note I don't know if it's a plugin issue. Further tests shows that
> it works OK when configuring the plugin in the reporting section:
>
>   <reporting>
>     <plugins>
>         <plugin>
>           <groupId>org.apache.maven.plugins</groupId>
>           <artifactId>maven-project-info-reports-plugin</artifactId>
>           <version>3.0.1</version>
>           <configuration>
>             <pluginManagementExcludes>
>
> <pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>
>             </pluginManagementExcludes>
>           </configuration>
>         </plugin>
>     </plugins>
>   </reporting>
>
> *BUT* if I configure the plugin in BOTH the pluginManagement and reporting
> section, then it fails again.
> Sounds to me like some plugin resolution condition that causes the
> pluginManagementExcludes list parameter to not be set.
>
>
> El sáb., 24 de ago. de 2019 a la(s) 17:32, Tibor Digana (
> tibordig...@apache.org) escribió:
>
> > that's bad. We were too fast :-)
> > Although my build passed but in this case as I saw the commit I have to
> > give my -1, sorry!
> >
> > On Sat, Aug 24, 2019 at 9:41 PM Gabriel Belingueres <
> belingue...@gmail.com
> > >
> > wrote:
> >
> > > Hi:
> > >
> > > Regarding MPIR-375, I noted that the merge of the PR into master branch
> > > was done *before* I made changes using PatternExcludesArtifactFilter
> > based
> > > on the reviews.
> > >
> > > See https://github.com/apache/maven-project-info-reports-plugin/pull/7
> .
> > > The commit in master is:
> > >
> >
> https://github.com/apache/maven-project-info-reports-plugin/commit/82f4bf23b79fe87d2e414c70ab2058e8f1b4146b
> > >
> > > The patch should work anyway so I decided to test it with the
> > > maven-shared-utils library.
> > > I added this to the pom.xml file (in addition to adding the
> > > staged-releases profile to settings.xml with the staged repo):
> > >
> > >     <pluginManagement>
> > >       <plugins>
> > >         <plugin>
> > >           <groupId>org.apache.maven.plugins</groupId>
> > >           <artifactId>maven-project-info-reports-plugin</artifactId>
> > >           <version>3.0.1</version>
> > >           <configuration>
> > >             <pluginManagementExcludes>
> > >
> > > <pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>
> > >             </pluginManagementExcludes>
> > >           </configuration>
> > >         </plugin>
> > >       </plugins>
> > >     </pluginManagement>
> > >
> > > With version 3.0.1, running 'mvn -V -Pstaged-releases clean site >
> > > 3.0.1.log' throws an exception. (see 3.0.1.log attached file)
> > >
> > > However, when building 3.0.2-SNAPSHOT and installing in the local repo
> > > (please see that in git repo there are no new commits after the 3.0.1
> > > release), changing the version to 3.0.2-SNAPSHOT works as expected:
> > >
> > > mvn -V -Pstaged-releases clean site > 3.0.2-SNAPSHOT.log
> > >
> > > Does anyone else is having this problem? Or am I doing something wrong?
> > >
> > > Kind regards,
> > > Gabriel
> > >
> > > El vie., 23 de ago. de 2019 a la(s) 16:33, Michael Osipov (
> > > micha...@apache.org) escribió:
> > >
> > >> Hi,
> > >>
> > >> We solved 5 issues:
> > >>
> > >>
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317821&version=12344828
> > >>
> > >> There are still a couple of issues left in JIRA:
> > >> https://issues.apache.org/jira/projects/MPIR/issues
> > >>
> > >> Staging repo:
> > >> https://repository.apache.org/content/repositories/maven-1528/
> > >>
> > >>
> >
> https://repository.apache.org/content/repositories/maven-1528/org/apache/maven/plugins/maven-project-info-reports-plugin/3.0.1/maven-project-info-reports-plugin-3.0.1-source-release.zip
> > >>
> > >> Source release checksum(s):
> > >> maven-project-info-reports-plugin-3.0.1-source-release.zip
> > >> sha512:
> > >>
> > >>
> >
> 7145430a6999ed65a886ac503793f0aa9488b6853431c494c3dee6360c05f3db53fe46ff77bd41514002e8c320b0f4623d23b85d3a9373450c90bb713d3e50be
> > >>
> > >> Staging site:
> > >>
> > >>
> >
> https://maven.apache.org/plugins-archives/maven-project-info-reports-plugin-LATEST/
> > >>
> > >> Guide to testing staged releases:
> > >>
> https://maven.apache.org/guides/development/guide-testing-releases.html
> > >>
> > >> Vote open for 72 hours.
> > >>
> > >> [ ] +1
> > >> [ ] +0
> > >> [ ] -1
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > >> For additional commands, e-mail: dev-h...@maven.apache.org
> > >>
> > >>
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> >
>

Reply via email to