+0.99 from Eclipse Tycho (test build https://ci.eclipse.org/tycho/job/tycho-build-with-maven-snapshots/31/ ) The only (minor) test failure is a regression in Maven 3.6.2 compared to 3.6.0 (Tycho couldn't work with 3.6.1 so cannot test it) and can be reproduced locally. The cause is most likely a different effective pom that leads to different configuration of mojos.
See the different value for `includeAllDependencies` from the same module, on test project https://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/tycho-its/projects/p2Repository.transitive?h=tycho-1.4.0 With Maven 3.6.0 ``` $ ~/apps/apache-maven-3.6.0/bin/mvn -X clean verify -Dtycho.version=1.4.0 -Dp2.repo=file://home/mistria/git/org.eclipse.tycho/tycho-its/repositories/oxygen/ Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T20:41:47+02:00) Maven home: /home/mistria/apps/apache-maven-3.6.0 Java version: 11.0.4, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-11-openjdk-11.0.4.11-0.fc30.x86_64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.2.9-200.fc30.x86_64+debug", arch: "amd64", family: "unix" [...] [INFO] --- tycho-p2-repository-plugin:1.4.0:assemble-repository (default-assemble-repository) @ repository-allDependencies --- [DEBUG] Configuring mojo org.eclipse.tycho:tycho-p2-repository-plugin:1.4.0:assemble-repository from plugin realm ClassRealm[plugin>org.eclipse.tycho:tycho-p2-repository-plugin:1.4.0, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@1affbebc] [DEBUG] Configuring mojo 'org.eclipse.tycho:tycho-p2-repository-plugin:1.4.0:assemble-repository' with basic configurator --> [DEBUG] (f) compress = true [DEBUG] (f) createArtifactRepository = true [DEBUG] (f) includeAllDependencies = true [DEBUG] (f) keepNonXzIndexFiles = true [DEBUG] (f) project = MavenProject: tycho-its-project.p2Repository.transitive:repository-allDependencies:1.0.0-SNAPSHOT @ /home/mistria/git/org.eclipse.tycho/tycho-its/projects/p2Repository.transitive/repository-allDependencies/pom.xml [DEBUG] (f) qualifier = 201908291420 [DEBUG] (f) repositoryName = repository-allDependencies [DEBUG] (f) session = org.apache.maven.execution.MavenSession@73dbe25 [DEBUG] (f) xzCompress = true [DEBUG] -- end configuration -- ``` With Maven 3.6.2 ``` $ ~/apps/apache-maven-3.6.2/bin/mvn -X clean verify -Dtycho-version=1.4.0 -Dp2.repo=file://home/mistria/git/org.eclipse.tycho/tycho-its/repositories/oxygen/ | more Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T17:06:16+02:00) Maven home: /home/mistria/apps/apache-maven-3.6.2 Java version: 11.0.4, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-11-openjdk-11.0.4.11-0.fc30.x86_64 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.2.9-200.fc30.x86_64+debug", arch: "amd64", family: "unix" [...] [INFO] --- tycho-p2-repository-plugin:1.4.0:assemble-repository (default-assemble-repository) @ repository-allDependencies --- [DEBUG] Configuring mojo org.eclipse.tycho:tycho-p2-repository-plugin:1.4.0:assemble-repository from plugin realm ClassRealm[plugin>org.eclipse.tycho:tycho-p2-repository-plugin:1.4.0, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@1affbebc] [DEBUG] Configuring mojo 'org.eclipse.tycho:tycho-p2-repository-plugin:1.4.0:assemble-repository' with basic configurator --> [DEBUG] (f) compress = true [DEBUG] (f) createArtifactRepository = true [DEBUG] (f) includeAllDependencies = false [DEBUG] (f) keepNonXzIndexFiles = true [DEBUG] (f) project = MavenProject: tycho-its-project.p2Repository.transitive:repository-allDependencies:1.0.0-SNAPSHOT @ /home/mistria/git/org.eclipse.tycho/tycho-its/projects/p2Repository.transitive/repository-allDependencies/pom.xml [DEBUG] (f) qualifier = 201908291425 [DEBUG] (f) repositoryName = repository-allDependencies [DEBUG] (f) session = org.apache.maven.execution.MavenSession@c4551c6 [DEBUG] (f) xzCompress = true [DEBUG] -- end configuration -- ``` I updated this dummy test to make it more proper: https://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=07b8f5a6e90ffaada7f8a6d13ea6acbf0c47a978 And ran again and it works: https://ci.eclipse.org/tycho/job/tycho-build-with-maven-snapshots/34/ So to me, from Tycho POV, it's not at all a blocker for the release; I even find it not interesting enough (at least in that case) to be reported as a bug, but it could be the symptom of some more important thing. I leave it to anyone else to pursue this track if anyone happens to find it important. This release of Maven 3.6.2 is still considered as a major improvement for Tycho and desired, even if with this glitch. Cheers, On Wed, Aug 28, 2019 at 9:18 PM Enrico Olivelli <[email protected]> wrote: > Hi, > > We have solved 52 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12345234 > > There are issues left in JIRA for Maven core: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC%2C%20updated%20DESC > > Staging repo: > https://repository.apache.org/content/repositories/maven-1529 > > The distributable binaries and sources can be found here: > > https://repository.apache.org/content/repositories/maven-1529/org/apache/maven/apache-maven/3.6.2/ > > Specifically the zip, tarball and source archives can be found here: > > > https://repository.apache.org/content/repositories/maven-1529/org/apache/maven/apache-maven/3.6.2/apache-maven-3.6.2-bin.zip > > https://repository.apache.org/content/repositories/maven-1529/org/apache/maven/apache-maven/3.6.2/apache-maven-3.6.2-bin.tar.gz > > > https://repository.apache.org/content/repositories/maven-1529/org/apache/maven/apache-maven/3.6.2/apache-maven-3.6.2-src.zip > > https://repository.apache.org/content/repositories/maven-1529/org/apache/maven/apache-maven/3.6.2/apache-maven-3.6.2-src.tar.gz > > The release artifacts are staged for distribution in: > https://dist.apache.org/repos/dist/dev/maven/maven-3/3.6.2 > > Source release checksum(s): > apache-maven-3.6.2-src.tar.gz > > sha1: 373ffbe9fc88e5facbe10d7a6f6badd243545ade > sha512: > > 235198b48d29fe2f2394f2607a9a1637acfd0286beacb974c566f7f36ac6c469871a0db287539b2b62e6322d7423f586949e41cbbfea330fe03bf690688f6fd7 > > apache-maven-3.6.2-src.zip: > > sha1: c6c5bd9828b3350905e97177978724eed0698de3 > sha512: > > d7fdafbc16bd547bc3c2513255df375c2a616b04d414c2ffd7d9deb9931fab5db4c7ac912cc4bb0d96d0a083560b3cc1848ea9eecc3aeb4e4c5184329a7ead5b > > Git tag: > > https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=40f52333136460af0dc0d7232c0dc0bcf0d9e117 > > Staging site: > https://maven.apache.org/components/ref/3-LATEST/ > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Kind regards > Enrico Olivelli > -- Mickael Istria Eclipse IDE <https://www.eclipse.org/downloads/eclipse-packages/> developer, for Red Hat Developers <https://developers.redhat.com/>
