If we can still log included deps are empty (agree it should be real deps and not these ones) elsewhere +1 (think otherwise it looks something went wrong in debug mode, no log does not mean empty if you follow me)
Le jeu. 19 déc. 2019 à 16:43, Anders Hammar <[email protected]> a écrit : > I agree. It's strange and the debug log output is actually > technically wrong. So I'd say remove it. > > /Anders > > On Thu, Dec 19, 2019 at 2:39 PM Mark Struberg <[email protected]> > wrote: > > > Hi! > > > > Feeling a bit rusty, so I thought I better ask for a 2nd opinion. > > > > To me it looks like the following code block is really obsolete and did > > not make anything useful ever since > > > > > > > https://github.com/apache/maven-assembly-plugin/blob/master/src/main/java/org/apache/maven/plugins/assembly/archive/task/AddDependencySetsTask.java#L112 > > > > > final List<Dependency> deps = project.getDependencies(); > > > if ( ( deps == null ) || deps.isEmpty() ) > > > { > > > logger.debug( "Project " + project.getId() + " has no dependencies. > > Skipping dependency set addition." ); > > > } > > > > 'deps' is never used. And it's just a logging. > > Plus all ITs plus a big custom project still fully pass if I remove the > > block. > > > > Any reason not to remove it? > > > > LieGrue, > > strub > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
