Can be useful, but it needs some improvement before apply: - default value for target should not be "_self", but should be nothing: the target attribute should not be added to the <a> element if not specified. Target is a deprecated html attribute (it's only supported in the transitional or frameset version of the dtds) so it's better to avoid it when possible.
- from an usability point of view, links that open in a new window should be at least marked differently from internal links. Since you are adding support for opening links in a new window, it will be nice to also automatically add a css class so that users can mark the link with a "new window" icon or a different color using css. So my suggestion is that links with a specified target should also be rendered with an added class="newwindow" For reference: http://www.smackthemouse.com/20030831 http://diveintoaccessibility.org/day_16_not_opening_new_windows.html I already was thinking about this addiction to xdoc. Another related enhancement is to add a css class (class="external") to all the external links (for example this can be useful for the "development process" link always pointing to maven site). The class should be added if the href value starts with "http". For a good example of a correct use of this see http://www.junitee.org/ (note the icons near to external links) If you agree with these suggestion and want a help on implementing them let me know, I can work on this. fabrizio -----Original Message----- From: Arnaud HERITIER [mailto:[EMAIL PROTECTED] Sent: sabato 24 aprile 2004 11.32 To: 'Maven Developers List' Subject: MPXDOC-97 - your opinion I enhanced the xdoc and added 2 little functionalities to the navigation : - allow to specify a target for the link for all items (links & menu)- Very useful to open a new page for pdf files, javadocs, etc. <menu ...> ... <item name="JavaDocs" href="/apidocs/index.html" target="_blank"/> ... </menu> - allow using an image in the page links <links> ... <item name="PDF Doc" href="/my_module.pdf" img="images/pdf.gif" target="_blank"/> ... </link> It's completely backward compatible with standard navigation.xml By default the target is "_self". You can find a demo here : http://www.apache.org/~aheritier/maven/ What do you think about these changes ?? #Arnaud --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
