I've found another reason to move it to core: the mvnw scripts are extended versions of the mvn scripts. If you do a diff, you'll recognize a block responsible for downloading the wrapper jar. But you also notice that all recent improvements on the mvn scripts have not been adopted. If you use the mvnw for Maven x.y.z, it should behalve as calling mvn of Maven x.y.z, now it doesn't. On 15-2-2020 13:27:38, Robert Scholte <rfscho...@apache.org> wrote: https://github.com/apache/maven-studies/blob/maven-wrapper/src/main/java/org/apache/maven/wrapper/MavenWrapperMain.java#L51
Here is the hard reference to the Maven Version. If this cannot be replaced, it'll be much easier to make maven wrapper part of Maven Core, so it can benefit from that version. Robert On 12-2-2020 21:23:59, Robert Scholte <rfscho...@apache.org> wrote: well, with every release of Maven, some versions needed to be updated, see the commit logs. Also the release instructions show some relation with the Maven version. Based on that it looks like it should be part of core. I've understood doing a release of is a bit problematic due to some chicken-egg issue. However, I did start with the plugin and that one is now capable of recognizing the runtime version of Maven, not hardcoded. So it depends, I just haven't figured it out yet. On 12-2-2020 20:28:24, Enrico Olivelli <eolive...@gmail.com> wrote: Il Mer 12 Feb 2020, 19:58 Robert Scholte ha scritto: > Hi, > > This month we've finished the incubator process to move to code from the > maven wrapper to our project. > Cool > > Initially the idea was to move both the maven-wrapper and the > takari-maven-plugin (which contains a wrapper goal) to our codebase, but > due to conflicting licensing we only moved the maven-wrapper. > > Right now I've moved the code of the maven-wrapper to his own branch under > maven-studies. > From here we can work on it. I think it makes sense to make it a module of > Maven core, but that's still a decision we need to make. > Is it strictly dependent on a Maven version? I thought it was totally independent. Why not having a separate repository and release lifecycle? Enrico > For the maven-wrapper-plugin a new repository has been created. And I've > started with a clean branch, trying to set the base of this plugin. > > Both are open for further development, not just by me. > > So here are the 2 new git repositories: > https://gitbox.apache.org/repos/asf/maven-wrapper-plugin.git > (branch MWRAPPER-0_WIP) > https://gitbox.apache.org/repos/asf/maven-studies.git (branch > maven-wrapper) > > > Enjoy, > Robert
