On Mon, May 4, 2020 at 5:17 PM Romain Manni-Bucau <rmannibu...@gmail.com> wrote:
> Le lun. 4 mai 2020 à 17:06, Stephane Nicoll <stephane.nic...@gmail.com> a > écrit : > > > Thanks but that doesn't really answer my question. That version is picked > > up by dependency management of the project as far as I can tell. If a > > project does provide an older junit engine version the build will break. > > > > If you meant to "force" a single version then I'd argue that you > shouldn't > > resolve the one provided in dependency management for the project. I also > > find this change quite suspicious in a maintenance release. > > > > > Long story short the first jupiter integration contributed by junit team > was supporting a single version. > This is what is in 2.x of surefire. > This maintenance release just upgraded the version as requested in a ticket > IIRC but didn't change the way it is loaded (which is done on master). > > As the author of the commit in question, I checked the compatibility with all latest JUnit Platform dot-releases (1.0.3 to 1.6.1) here: [0] -- with simple projects that e.g. don't require Spring Boot or any other library/framework. To me, those successful checks made be think, that this internal detail, the JUnit Platform version Surefire runs on, would not impact external projects. Having said that, if we don't find a working solution (including a new test-case) for most parties involved, I'm open to revert that change and let only the SB-found-and-fixed commit ship with Surefire 2.22.3. Cheers, Christian [0]: https://github.com/apache/maven-surefire/blob/7d5cbc230b181f83b24c8cb669d45c20ffbdcb2f/surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java#L59-L65
