michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427584057
##########
File path: pom.xml
##########
@@ -211,6 +211,8 @@ under the License.
<projectInfoReportsPluginVersion>2.7</projectInfoReportsPluginVersion>
<surefirePluginVersion>2.22.1</surefirePluginVersion>
<project.build.outputTimestamp>2020-03-06T20:49:49Z</project.build.outputTimestamp>
+ <maven.compiler.target>1.8</maven.compiler.target>
Review comment:
I am confused. We have `javaVersion`. Why did you set these too?
##########
File path: pom.xml
##########
@@ -473,28 +474,28 @@ under the License.
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
- <version>1.5.3</version>
+ <version>1.7.29</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
- <version>1.5.3</version>
+ <version>1.7.29</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>jcl-over-slf4j</artifactId>
- <version>1.6.1</version>
+ <version>1.7.29</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
- <version>3.4</version>
+ <version>3.5</version>
Review comment:
Seems unrelated.
##########
File path: pom.xml
##########
@@ -473,28 +474,28 @@ under the License.
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
- <version>1.5.3</version>
+ <version>1.7.29</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
- <version>1.5.3</version>
+ <version>1.7.29</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>jcl-over-slf4j</artifactId>
- <version>1.6.1</version>
+ <version>1.7.29</version>
Review comment:
This should be a property and match the version on Maven core.
##########
File path: pom.xml
##########
@@ -623,6 +624,7 @@ under the License.
<maven.compiler.source>${maven.compiler.source}</maven.compiler.source>
<maven.compiler.target>${maven.compiler.target}</maven.compiler.target>
</properties>
+ <javaHome>${java.home}</javaHome>
Review comment:
Why is that necessary?
##########
File path: src/it/projects/new-configuration/pom.xml
##########
@@ -76,7 +76,7 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
- <version>2.7</version>
+ <version>@javadocPluginVersion@</version>
Review comment:
How are these related?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
