+1 (non binding) Side note: I see from the diff (good idea!) that we added a new comment with 'TODO' We should create a JIRA and link to it.
Enrico Il Sab 23 Mag 2020, 14:12 Robert Scholte <rfscho...@apache.org> ha scritto: > +1 > > > On 23-5-2020 13:03:20, Arnaud Héritier <aherit...@gmail.com> wrote: > LGTM +1 > I did only a code review using > https://github.com/apache/maven-wagon/compare/wagon-3.4.0...wagon-3.4.1 > > On Fri, May 22, 2020 at 9:45 PM Michael Osipov wrote: > > > Hi, > > > > We solved 6 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318122&version=12348210 > > > > There are still a couple of issues left in JIRA: > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20WAGON%20AND%20resolution%20%3D%20Unresolved > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-1576/ > > > > > https://repository.apache.org/content/repositories/maven-1576/org/apache/maven/wagon/wagon/3.4.1/wagon-3.4.1-source-release.zip > > > > Source release checksum(s): > > wagon-3.4.1-source-release.zip > > sha512: > > > > > 342d3ad88ba3535a0b6cafcfebd3f5b2e0fc6ac4022bebcea78a60703b0c611232e765ea87fb98ada0dc5daf1a9002e9bf7959571eebc4c974efda042246999c > > > > Staging site: > > https://maven.apache.org/wagon-archives/wagon-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- > ----- > Arnaud Héritier > http://aheritier.net > Mail/GTalk: aheritier AT gmail DOT com > Twitter/Skype : aheritier >
