Even if it works you should still add the test cases you talked about.

--
Trygve

On Wed, 12 May 2004 14:51:23 +0200, Vincent Massol <[EMAIL PROTECTED]> wrote:

Cool. Thanks Brett! Does it work?

-Vincent

-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: 12 May 2004 14:44
To: [EMAIL PROTECTED]
Subject: cvs commit: maven/src/test/touchstone-build maven.xml

brett 2004/05/12 05:44:09

Modified: src/test/touchstone-build Tag: MAVEN-1_0-BRANCH
maven.xml
  Log:
  add tests for maven:get and maven:set

  Revision  Changes    Path
  No                   revision
  No                   revision
  1.43.4.16 +21 -0     maven/src/test/touchstone-build/maven.xml

  Index: maven.xml
  ===================================================================
  RCS file: /home/cvs/maven/src/test/touchstone-build/maven.xml,v
  retrieving revision 1.43.4.15
  retrieving revision 1.43.4.16
  diff -u -r1.43.4.15 -r1.43.4.16
  --- maven.xml 11 May 2004 09:48:16 -0000      1.43.4.15
  +++ maven.xml 12 May 2004 12:44:09 -0000      1.43.4.16
  @@ -216,6 +216,7 @@
       <attainGoal name="test-inheritence" />
       <attainGoal name="test-non-jar-dependency-path" />
       <attainGoal name="test-entity-goal" />
  +    <attainGoal name="test-plugin-getset" />

   <!-- TODO - this is still broken (as in RC1)
       <attainGoal name="test-reactor-maven-username" />
  @@ -818,6 +819,26 @@
         goals=""
         ignoreFailures="false"
       />
  +  </goal>
  +
  +  <goal name="test-plugin-getset">
  +    <attainGoal name="touchstone-goal-B"/>
  +    <echo>test maven:get</echo>
  +    <maven:get var="checkValue" plugin="maven-touchstone-plugin"
property="touchstone_goal_B_from_plugin"/>
  +    <j:if test="${checkValue != 'true'}">
  +      <fail message=""> maven:get failed </fail>
  +    </j:if>
  +    <echo>test maven:pluginVar (deprecated)</echo>
  +    <maven:pluginVar var="checkValue"
plugin="maven-touchstone-plugin"
property="touchstone_goal_B_from_plugin"/>
  +    <j:if test="${checkValue != 'true'}">
  +      <fail message=""> maven:pluginVar failed </fail>
  +    </j:if>
  +    <echo>test maven:set</echo>
  +    <maven:set plugin="maven-touchstone-plugin"
property="touchstone_goal_B_from_plugin" value="blah"/>
  +    <maven:get var="checkValue" plugin="maven-touchstone-plugin"
property="touchstone_goal_B_from_plugin"/>
  +    <j:if test="${checkValue != 'blah'}">
  +      <fail message=""> maven:set failed </fail>
  +    </j:if>
     </goal>
   </project>

--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to