> On 17 Jul 2020, at 10:42, Dennis Lundberg <[email protected]> wrote: > > Hi, > > I'm checking the scope of releasing maven-resources-plugin. There is > currently a transitive dependency chain like this: > - maven-resources-plugin depends upon > - maven-filtering 3.2.0-SNAPSHOT depends upon > - maven-shared-utils 3.3.0-SNAPSHOT > > That last SNAPSHOT was added in > https://github.com/apache/maven-filtering/commit/17fe0c18929be13fb75b00d76628dc7146f85aec > but it does not seem related to the commit message or the other changes in > the commit. So I'm curious, does maven-filtering really need the latest > version of maven-shared-utils? The build with tests succeeds if I turn it > back to the latest stable version 3.2.1.
The message of that commit doesn’t make much sense to me but the timing of the commit ties in with my recent work! I’d certainly love this chain of releases to happen as it would allow MRESOURCES-258 to be closed. I think MRESOURCES-236 is in the same position. maven-shared-utils was modified to fix the underlying issue: https://github.com/apache/maven-shared-utils/pull/28 maven-filtering was modified to reuse the matching (but improved) methods in maven-shared-utils: https://github.com/apache/maven-filtering/pull/6 I didn’t replicate tests for improved behaviour upstream in maven-resources-plugin, hence the maven-resources-plugin tests not breaking. I can replicate the tests upstream and prove them in the maven-resources-plugin context if you’d prefer? > Note that there is also a pending pull request that does away with many, > but not all, usages of maven-shared-utils classes in maven-filtering. I'd > like for that to be merged and included in the upcoming releases. > https://github.com/apache/maven-filtering/pull/13 Is there an implication here that we’re trying to drop dependencies on maven-shared-utils? If so, I’m happy to revert https://github.com/apache/maven-filtering/pull/6 and port the https://github.com/apache/maven-shared-utils/pull/28 directly to maven-filtering. Let me know and I can tackle over the weekend! (would love to get this released!) Thanks, Rob --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
