pzygielo commented on pull request #10:
URL: https://github.com/apache/maven-archiver/pull/10#issuecomment-685128506


   > That's not something I'm worried about happening in practice. 
   
   I know. But I do.
   
   So I've updated my example for the case, where this dependency is overriden 
in assembly plugin (i.e. archiver is no longer direct dependency of code in my 
example, but is utilized by plugin).
   
   Per http://maven.apache.org/plugins/maven-assembly-plugin/dependencies.html 
assembly plugin uses archiver in version 3.5.0 (the latest).
   
   Per 
https://maven.apache.org/guides/mini/guide-configuring-plugins.html#Using_the_dependencies_Tag:
   > You could configure the dependencies of the Build plugins, commonly to use 
a more recent dependency 
   > version.
   
   So I do in my example, pretending that 3.5.1-SNAPSHOT is released now and I 
like other changes in it, and there is no better release of assembly plugin. 
Example shows that proposed change is not backward compatible.
   
   ---
   I'm only saying, that if there is no other way - it shall be reflected in 
version of plugin, as per https://semver.org/, which might not be observed here 
but is kind of standard:
   > increment MAJOR version when you make incompatible API changes,
   
   or **at least** as @mabrarov said - very clearly stated in RN.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to