elharo commented on a change in pull request #205:
URL: https://github.com/apache/maven-site/pull/205#discussion_r499269010



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   One of the goals in Maven 2 is to consolidate all the information needed to
   run a build into a single file, or file hierarchy which is the POM.
 
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite the global 
elements with the same name of the POM or extend those in case of collections.

Review comment:
       I think you can delete "of the POM"

##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   One of the goals in Maven 2 is to consolidate all the information needed to
   run a build into a single file, or file hierarchy which is the POM.
 
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite the global 
elements with the same name of the POM or extend those in case of collections.
+In case multiple profiles are active in the same POM or external file, the 
ones which are defined <<later>> take precedence over the ones defined 
<<earlier>> (independent of their profile id and activation order).

Review comment:
       I'm not sure you need "independent of their profile id and activation 
order" but if you do, you can drop the parentheses. 

##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   One of the goals in Maven 2 is to consolidate all the information needed to
   run a build into a single file, or file hierarchy which is the POM.
 
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite the global 
elements with the same name of the POM or extend those in case of collections.
+In case multiple profiles are active in the same POM or external file, the 
ones which are defined <<later>> take precedence over the ones defined 
<<earlier>> (independent of their profile id and activation order).

Review comment:
       In case --> If
   

##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   One of the goals in Maven 2 is to consolidate all the information needed to

Review comment:
       up to you, but otherwise I might be inspired to send a PR to fix this 
that conflicts with this one. :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to