I'll change this, once INFRA-20938 [1] is solved. Currently, toolchain.xml is missing on Windows build nodes, it only works on linux nodes.
The current branch, I'm working on, contains the proper usage of invoker: [2] Regards, Andreas [1] https://issues.apache.org/jira/browse/INFRA-20938 [2] https://github.com/apache/maven-pmd-plugin/tree/test-INFRA-20938 Am 25.10.20 um 12:06 schrieb Robert Scholte: > I won't hijack the voting thread, but I'd like to share some info about a > feature that should have been used here[1]: > > # A mapping for toolchain to ensure it exists # Since plugin version 3.2.0 > invoker.toolchain.<type>.<provides> = value invoker.toolchain.jdk.version = 11 > This will check if the toolchain is available, otherwise it'll skip the test. > Jenkins at ASF has toolchains in place[2], so there's no need to have > explicit paths in your test. > > thanks, > Robert > > [1] > https://maven.apache.org/plugins/maven-invoker-plugin/run-mojo.html#invokerPropertiesFile > [2] > https://github.com/apache/infrastructure-puppet/blob/deployment/modules/build_slaves/files/toolchains.xml > > On 24-10-2020 23:44:45, Tibor Digana <[email protected]> wrote: > +1 > > In general, the build works but i have a problem with this statement in the > file selector.groovy > String jdk11Windows = 'f:\\jenkins\\tools\\java\\latest11' > > IMO the value should be configured via a system property. It should not be > hard coded like it is written above. > And, if the path does not exist then this test should not be executed or > the test result should be ignored otherwise. > Also the README.md should express this exception and configuration too. > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-toolchains-plugin:3.0.0:toolchain (default) > on project MPMD-304-toolchain-support: Misconfigured toolchains. > Non-existing JDK home configuration at e:\Program Files\Java\jdk-11 -> > [Help 1] > > On Sat, Oct 24, 2020 at 7:46 PM Andreas Dangel wrote: > >> Hi, >> >> We solved 9 issues: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12346940&styleName=Text&projectId=12317621 >> >> There are still a couple of issues left in JIRA: >> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPMD%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC >> >> Staging repo: >> https://repository.apache.org/content/repositories/maven-1611/ >> >> https://repository.apache.org/content/repositories/maven-1611/org/apache/maven/plugins/maven-pmd-plugin/3.14.0/maven-pmd-plugin-3.14.0-source-release.zip >> >> Source release checksum(s): >> maven-pmd-plugin-3.14.0-source-release.zip sha512: >> >> b20cc1611abe5bdd5eed39bb5b7c0f601bcbba11dd98650f9fbdf3c8dcee996232904b39b6aaca0fde741c9ddc834433acf6f2eb79bc97821c22b6e2b257f706 >> >> Staging site: >> https://maven.apache.org/plugins-archives/maven-pmd-plugin-LATEST/ >> >> Guide to testing staged releases: >> https://maven.apache.org/guides/development/guide-testing-releases.html >> >> Vote open for at least 72 hours. >> >> [ ] +1 >> [ ] +0 >> [ ] -1 >> >> >> Regards, >> Andreas >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
