> -----Original Message-----
> From: Brett Porter [mailto:[EMAIL PROTECTED]
> Sent: 11 May 2004 08:48
> To: 'Maven Developers List'
> Subject: RE: cvs commit: maven-plugins/artifact/xdocs changes.xml
> 
> Probably? Definitely :)
> 
> I don't think this is a per dependency attribute. It's a mapping that
> needs
> to be configurable, but global.

That would be even better... :-)

-Vincent

> 
> - Brett
> 
> > -----Original Message-----
> > From: Vincent Massol [mailto:[EMAIL PROTECTED]
> > Sent: Tuesday, 11 May 2004 4:20 AM
> > To: 'Maven Developers List'
> > Subject: RE: cvs commit: maven-plugins/artifact/xdocs changes.xml
> >
> >
> > +1 to create an <extension> tag which defaults to "jar":
> >
> > <dependency>
> >   [...]
> >   <type>myowntype</type>
> >   <extension>myowntypeextension</extension>
> > </dependency>
> >
> > However that's probably for Maven 1.1.
> >
> > Thanks
> > -Vincent
> >
> > > -----Original Message-----
> > > From: [EMAIL PROTECTED]
> > [mailto:[EMAIL PROTECTED]
> > > Sent: 11 May 2004 02:03
> > > To: Maven Developers List
> > > Subject: Re: cvs commit: maven-plugins/artifact/xdocs changes.xml
> > >
> > > [EMAIL PROTECTED] wrote on 11/05/2004 09:36:35 AM:
> > >
> > > > brett       2004/05/10 16:36:35
> > > >
> > > >   Modified:
> > artifact/src/main/org/apache/maven/artifact/deployer
> > > >                         DefaultArtifactDeployer.java
> > > >                artifact/xdocs changes.xml
> > > >   Log:
> > > >   PR: MPUBERJAR-5
> > > >   give uberjar type a jar extension
> > > >
> > > >   Revision  Changes    Path
> > > >   1.18      +5 -1      maven-
> > > >
> > >
> > plugins/artifact/src/main/org/apache/maven/artifact/deployer/D
> > efaultArti
> > fa
> > > ctDeployer.
> > > > java
> > > >
> > > >   Index: DefaultArtifactDeployer.java
> > > >
> > ===================================================================
> > > >   RCS file: /home/cvs/maven-
> > > >
> > >
> > plugins/artifact/src/main/org/apache/maven/artifact/deployer/D
> > efaultArti
> > fa
> > > ctDeployer.
> > > > java,v
> > > >   retrieving revision 1.17
> > > >   retrieving revision 1.18
> > > >   diff -u -r1.17 -r1.18
> > > >   --- DefaultArtifactDeployer.java   2 May 2004 15:04:34 -0000
> > 1.17
> > > >   +++ DefaultArtifactDeployer.java   10 May 2004 23:36:34 -0000
> > 1.18
> > > >   @@ -513,6 +513,10 @@
> > > >            {
> > > >                return "jar";
> > > >            }
> > > >   +        else if (type.equals("uberjar"))
> > > >   +        {
> > > >   +            return "jar";
> > > >   +        }
> > > >            return type;
> > > >        }
> > > >    }
> > >
> > > I'd much rather the artifact code externalised the mapping from
type
> > to
> > > extension. Otherwise it will become a place of continual churn.
> > > --
> > > dIon Gillard, Multitask Consulting
> > >
> > >
> > >
> >
---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to