batch mode means no interaction, but the debug-flag is an interaction (java process is waiting for input). So it doesn't make sense to have both activated. This will prevent CI jobs to hang when using --debug (if they assume this means logging at debug level) batch implies disabling colours, but if you *only* want to disable colors, you should use -Dstyle.color=never
Robert On 27-7-2021 13:56:45, Michael Osipov <[email protected]> wrote: OK, let me sum up what you are proposing: Am 2021-07-27 um 12:39 schrieb Robert Scholte: > I actually like the idea of renaming --debug/-X to --verbose/-X and we're > actually lucky. > When renaming we can add a message that --debug for logging at debug level > has been renamed to --verbose. A preceding commit will rename --debug to verbose. This PR will reuse --debug instead of -dj/--debug-java. I assume that most do -X and not --debug, but that's a wild guess. > Due to the nature of debugging (waiting until remote debugger is attached) > the message will be visible so users can easily kill the running process and > restart Maven with the new command. > In case of batch-mode as done by CI servers I think we can ignore the > --debug-flag, so if they were using the --debug flag, they'll just get less > logging. Here you expect that -B and --debug (new) are mutually exclusive? I don't know how likely it is, but maybe someone whats to debug w/o colors, send to file or omit the progress. Is that what you have in mind? M > On 26-7-2021 21:00:26, Michael Osipov wrote: > Hi folks, > > I was recently working on MNG-7075 and while the solution is straight > forward [1], it just feels awkward. For a long time I had the idea that > the mvnDebug script can be completely collapsed into mvn with a single > switch. > Therefore, I have created a draft PR [2] which works in the Windows > command prompt and the Bourne shell. It completely obsoletes MNG-7075, > mvnDebug and a nice bonus: When mvnDebug is run, output still refers to > 'mvn', e.g., 'mvn -r ' this is inconsistent until now, but will be > consistent in the future. mvnDebug would remain as-is, but would emit a > warning that it is deprecated. > mvnDebug is used ony by Maven developers like us and of course > extension/plugin devs. The majory are just users which don't care. > > Note: I am not happy with -dj, but wasn't able to come up with something > better for the moment. I would prefer --debug to be renamed to --verbose > and --debug to be recycled as Java debug mode, but that is likely > impossible, I guess. > > WDYT? > > Michael > > [1] https://github.com/apache/maven/pull/515 > [2] https://github.com/apache/maven/pull/517 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
