My main remark - after reading the original post - is already captured in the thread: having method parameters declared Optional<?> feels like an anti-pattern to me. If must be, there could be an overload, but a null parameter would be consistent with the existing API.

I think for Maven to be able to produce reproducible builds, we don't really need that Comparator.

Decide for yourself if you feel it's worth adding that to the existing thread...


Maarten

On 24/08/2021 16:24, Robert Scholte wrote:
FYI: A discussion has started on core-libs-dev mailinglist[1] about extending java.util.Properties with methods to storeĀ  properties files in a reproducible way. If you have any comments, subscribe to the mailinglist[2] or ask me to drop the comments.

thanks,
Robert

[1] https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-August/080758.html
[2] https://mail.openjdk.java.net/mailman/listinfo/core-libs-dev

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to