ITs updated to run mvnw MWRAPPER-22 proven to require to reapply the fix: done (surprising that nobody found that bug in Wrapper 0.5.6 and previous for more than 2 years...)
release ready to be done: I'll launch it tonight Regards, Hervé Le dimanche 12 décembre 2021, 19:05:33 CET Robert Scholte a écrit : > Jason, > > my point is that i DID write integration tests as part of the donation > to better understand the code, improve the codebase and its reliability. > While writing them I did find several issues, some caused because the > scripts didn't get in sync with the Maven core scripts. > So it is possible to automate these tests, they are there, somebody just > has to ported them to the new project. > Also with the change of strategy how the wrapper should work we need > integration-tests to confirm it all works. > We shouldn't gamble, as almost every release people will only test is > _after_ its vote, which is just too late. > > Robert > > [1] > https://github.com/apache/maven-integration-testing/tree/master/core-it-suit > e/src/test/resources/mng-5937%20wrapper > > ------ Origineel bericht ------ > Van: "Jason van Zyl" <ja...@vanzyl.ca> > Aan: "Maven Developers List" <dev@maven.apache.org> > Verzonden: 12-12-2021 13:54:16 > Onderwerp: Re: reviewing Maven Wrapper before releasing > > >Clearly no one here disagrees with the goal of having robust testing for > >software that is made available to users. > > > >As to the timing of that testing being complete for the wrapper, to the > >satisfaction of those objecting to a release, I will argue. > > > >Do we wait four years for adequate testing? I’m not being facetious because > >we’re rolling up on three years since the initial donation of the wrapper > >was made. No one can force anyone else to do work here, sometimes things > >take a while, and there still may be a great deal of time that passes > >before testing is present that is considered adequate. > > > >All else being equal, I think the value of a release to remove the state of > >limbo the wrapper has been in for years outweighs the current lack of > >testing. The wrapper has been in use for 8 years, and while more testing > >is preferred we have reasonable assurances it works as expected. I don’t > >think we’ll be back to zero if we find issues, they can be fixed and will > >be accompanied by tests as most things here are. Right now from a user’s > >perspective the wrapper appears dead at Takari and Apache which is a > >shame. > > > >Would everyone be amenable to an alpha release? And transition to a > >non-alpha release when everyone agrees the testing is sufficient? > > > >jvz > > > >> On Dec 12, 2021, at 5:14 AM, Maarten Mulders <mthmuld...@apache.org> > >> wrote: > >> > >> Chiming in a little late, but here are my 2 cents nevertheless. I would > >> not feel confident releasing something that we cannot test in an > >> automated way. Not having an integration test suite means we don't know > >> for sure if it works. And if we know it works and we change something, > >> we're back to zero. > >> > >> To me, this has nothing to do with a (misplaced) drive for perfection. > >> It is all about making sure we ship something to users that we know to > >> work, and that we can easily prove to still work after we change it. > >> > >> Thanks, > >> > >> Maarten > >> > >> On 11/12/2021 13:43, Robert Scholte wrote: > >>> It was marked for Maven 4, and part of the improvements was test > >>> automation, which was now possible because it became part of Maven > >>> Core. Even thought the code still exists in Maven Core, is has now > >>> become useless. There hasn't been a real need for new releases of > >>> Maven Wrapper Plugin until a range of Maven 3.8 started. Maven Wrapper > >>> would have been another feature to attract developers to Maven 4. And > >>> finally, I see that the donated code has been used as base, ignoring > >>> all the effort done to improve that codebase done afterwards. Hence my > >>> response that reliability is gone that was added after donation. > >>> Robert > >>> ------ Origineel bericht ------ > >>> Van: "Manfred Moser" <manf...@simpligility.com> > >>> Aan: dev@maven.apache.org > >>> Verzonden: 10-12-2021 20:58:33 > >>> Onderwerp: Re: reviewing Maven Wrapper before releasing > >>> > >>>> I totally agree with finally just shipping this. We got this all > >>>> donated about two years ago now and there is still nothing shipping. > >>>> > >>>> I used to just manually do the testing and thousands of projects are > >>>> happy. I assume the new project is at least manually testing and > >>>> works as before or better. Let's not wait nay more and let perfection > >>>> get into our way. It surely is good enough for a release. > >>>> > >>>> The beauty is that if you find an issue.. you just ship again ... no > >>>> reason to wait. > >>>> > >>>> manfred > >>>> > >>>> Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): > >>>>> the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I > >>>>> did not > >>>>> test, I just did not change anything using the general approach > >>>>> "people were happy before, just continue step by step improvements" > >>>>> :) > >>>>> > >>>>> reading the mvnw script (*nix), compiling+running the .java is > >>>>> executed only if neither wget nor curl are available on your > >>>>> machine > >>>>> > >>>>> reading the mvnw.cmd, it seems .java is not supported > >>>>> > >>>>> looking at Git history confirms: > >>>>>https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd > >>>>>7746d01b00e70337>>>>> > >>>>> Don't hesitate to create a Jira issue and corresponding fix to add > >>>>> .java > >>>>> support for Windows: future 3.1.0 will have one more fix over > >>>>> previous 0.5.6 > >>>>> > >>>>> Regards, > >>>>> > >>>>> Hervé > >>>>> > >>>>> Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : > >>>>>> I need more time. > >>>>>> > >>>>>> e.g. it looks like type=source doesn't use the Java sourcefile to > >>>>>> download the wrapper. > >>>>>> now that the plugin and wrapper are combined in one project, the > >>>>>> ITs are > >>>>>> incomplete. > >>>>>> They should call both the wrapper-goal and something like 'mvnw > >>>>>> --version' to ensure it is working (this used to be done in > >>>>>> maven-integration-testing) > >>>>>> > >>>>>> thanks, > >>>>>> Robert > >>>>>> > >>>>>> ------ Origineel bericht ------ > >>>>>> Van: "Hervé BOUTEMY" <herve.bout...@free.fr> > >>>>>> Aan: "Maven Developers List" <dev@maven.apache.org> > >>>>>> Verzonden: 10-12-2021 08:08:57 > >>>>>> Onderwerp: Re: reviewing Maven Wrapper before releasing > >>>>>> > >>>>>> >thank you to everybody who reviewed, discussed, contributed > >>>>>> > > >>>>>> >we now have 16 issues fixed, everything seems stable > >>>>>> > > >>>>>> >if nobody objects, I'll start a release over the week-end > >>>>>> > > >>>>>> >Regards, > >>>>>> > > >>>>>> >Hervé > >>>>>> > > >>>>>> >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > >>>>>> >> Hi, > >>>>>> >> > >>>>>> >> Maven Wrapper has been donated to Apache Maven, imported to > >>>>>> >> > >>>>>> >>https://github.com/apache/maven-wrapper > >>>>>> >> > >>>>>> >> Documentation published to https://maven.apache.org/wrapper/ > >>>>>> >> > >>>>>> >> Here is the list of fixes from previous 0.5.6 release: > >>>>>> >>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId= > >>>>>> >>12323721& > >>>>>> >>ve>> > >>>>>> >> > >>>>>> >> rsion=12350068 > >>>>>> >> > >>>>>> >> > >>>>>> >> Please test and review so we can do a release soon > >>>>>> >> > >>>>>> >> Regards, > >>>>>> >> > >>>>>> >> Hervé > >>>>>> >> > >>>>>> >> > >>>>>> >> > >>>>>> >> --------------------------------------------------------------- > >>>>>> >> ------ > >>>>>> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>>>>> >> For additional commands, e-mail: dev-h...@maven.apache.org > >>>>>> > > >>>>>> >------------------------------------------------------------------ > >>>>>> >--- > >>>>>> >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>>>>> >For additional commands, e-mail: dev-h...@maven.apache.org > >>>>>> > >>>>>> ------------------------------------------------------------------- > >>>>>> -- > >>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>>>>> For additional commands, e-mail: dev-h...@maven.apache.org > >>>>> > >>>>> -------------------------------------------------------------------- > >>>>> - > >>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>>>> For additional commands, e-mail: dev-h...@maven.apache.org > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>>> For additional commands, e-mail: dev-h...@maven.apache.org > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >>> For additional commands, e-mail: dev-h...@maven.apache.org > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > >--------------------------------------------------------------------- > >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >For additional commands, e-mail: dev-h...@maven.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
