slawekjaranowski commented on a change in pull request #8:
URL: https://github.com/apache/maven-reporting-exec/pull/8#discussion_r791119067
##########
File path: pom.xml
##########
@@ -170,7 +145,13 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>4.13.1</version>
+ <version>4.13.2</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-simple</artifactId>
+ <version>1.7.32</version>
Review comment:
I don't like putting dependencies in parent pom, especially when parent
is used by many components.
One project can use junit4 and another juni5 ....
`dependencyManagement` will be ok, for such purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
