Hi Sebastien,
On 18.05.22 17:57, Sebastien Doyon wrote:
Hi,
Recently I found some small potential improvements that could help clean the
maven code. I would be glad to contribute it back to my most useful Java
project, if you find it of interest.
The changes are mostly :
- Use of Collections.emptyList() instead of new ArrayList() when possible.
- Use of Collections.emptyMap() instead of new concrete Map object when possible
- Use of Collections.singletonList() instead of new concrete List object when
possible
It depends on where this changes can/should be done?..
- Guarding logging statements with conditionals on isXXXXEnabled() to avoid
garbage
In which way?
- Replacing StringBuilder or StringBuffer usage when + operator is more
appropriate
- Various small improvements
Please tell me if this is something that can be contributed to the Maven
project and I will proceed with the creation a Jira ticket and GitHub PR. You
can find the changes on this branch :
I would suggest that you first create a JIRA issue and start with small
improvements... and create a PR for that to start the process..
https://github.com/sebastien-doyon/maven/tree/codeImprovements2022
I've taken a look at that repo but unfortunately I can't see any
change... apart from that the repo is not in sync with the current
master of Maven.
BTW: You email does not work..
Kind regards
Karl Heinz
Please note that this would be my first contribution to the project and I would
like to do more in the futur. I am looking forward for your comment/review.
Regards
Sebastien Doyon
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
