given in the past, maven-shared-utils was expected to replace in the long term plexus-utils and give us more a Maven-centric view, yes, I added the Maven-specific logging code in maven-shared-utils in 2016
if we finally go the other way now, and create a new lib, we'll need to avoid the same situation in a few years On 2022/06/27 06:42:18 Konrad Windszus wrote: > Thanks for the feedback. > This package depends on JAnsi and is pretty Maven-specific > (https://github.com/apache/maven-shared-utils/blob/master/src/main/java/org/apache/maven/shared/utils/logging/Style.java), > so therefore probably not a good fit for the Maven-agnostic plexus-utils. > > I use it for example for custom Maven enforcer rules (to emit warnings with > some more colours/styling) and also plan to use it for this > filevault-package-maven-plugin > (https://issues.apache.org/jira/browse/JCRVLT-635). > > So probably either a dedicated new shared component > (https://maven.apache.org/shared/index.html) or maybe even > https://github.com/apache/maven/tree/master/maven-plugin-api/src/main/java/org/apache/maven/plugin/logging > (but again that would only affect future Maven versions). > Konrad > > On 2022/06/26 21:27:10 Tamás Cservenák wrote: > > Howdy, > > > > I am unsure if this would fit to plexus-utils... does this depend on jansi > > or something? > > I'd rather create a new module (if broadly used, many dependents) or fit > > it somewhere else... > > > > Where is this currently used? > > > > T > > > > On Sun, Jun 26, 2022 at 6:53 PM Konrad Windszus <k...@apache.org> wrote: > > > > > Sorry to reuse this thread, but another package which is not provided by > > > another library/artifact yet is > > > https://maven.apache.org/shared/maven-shared-utils/apidocs/org/apache/maven/shared/utils/logging/package-summary.html > > > . > > > > > > I would like to get rid of the maven-shared-utils dependency. Would you > > > accept a PR for https://github.com/codehaus-plexus/plexus-utils to add > > > that maven-shared-utils package (obviously relocated to > > > "org.codehaus.plexus.util.logging and ".logging.impl") to plexus-utils? > > > > > > (I know that this was recently added to the upcoming Maven 4 API in > > > https://github.com/apache/maven/pull/703/commits/8958f05171b715f2dd7ee95a5b37a6ca6184b6f4 > > > but I need a solution until that is widely supported...). > > > > > > Thanks for your input in advance, > > > Konrad > > > > > > On 2022/06/24 18:12:21 Slawomir Jaranowski wrote: > > > > Hi, > > > > > > > > maven-shared-utils has many deprecated stuff and looks like we want to > > > bury > > > > this project. > > > > > > > > I want to fix the issue: MSHARED-1072 [1] ... is in maven-shared-utils > > > > project > > > > > > > > I need it in maven-invoker, which is used by m-release-p for executing > > > fork > > > > builds ... > > > > > > > > So I've tried to see if it is possible to move code responsible for the > > > cli > > > > process from shared-utils to invoker .... > > > > > > > > but ... looks like package org.apache.maven.shared.utils.cli is even > > > > widely used [2], so coping code is not good > > > > > > > > Some other idea? > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/MSHARED-1072 > > > > [2] > > > > > > > https://github.com/search?l=Java&p=7&q=org.apache.maven.shared.utils.cli&type=Code > > > > -- > > > > Sławomir Jaranowski > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
