Hi again, thanks Slawomir and Michael for reviewing and merging the additional PRs I created that fix both the GitHub artifact upload and the failing build on Linux with JDK 18.
I'd like to renew my request for a review of the PR I originally intended to get merged (#568) which would fix the bug SUREFIRE-2117. I've rebased the branch and the checks for the PR are all green now. Maybe someone can find time to have a look. It's not a lot of production code changes, just 10 lines in one method of one class. Most of the PR is additional unit tests and ITs, but those do not require as much scrutiny I suppose. Best regards, Andreas -----Ursprüngliche Nachricht----- Von: Slawomir Jaranowski <[email protected]> Gesendet: Donnerstag, 15. Dezember 2022 14:29 An: Maven Developers List <[email protected]> Betreff: Re: Surefire Plugin Pull Requests Hi, Root cause for it is failing test: org.apache.maven.surefire.its.ConsoleOutputIT.properNewlinesAndEncodingWithDifferentEncoding Error which you see is from the GH job which tries to attach logs in case of failed build .... but on linux os is executed a test which checks a special path .... and such path is left in workspace after executing .... but is not valid for GH ... We should try to restore the original path after test_surefire-1617 to make the GH job work. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
