What was left out: get rid of get rid org.apache.maven.shared.dependency.graph.DependencyGraphBuilder and replace it with direct resolver, you can find plenty of examples here https://github.com/apache/maven-resolver/tree/master/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples
HTH Tamas On Mon, Jun 26, 2023 at 11:42 AM Tamás Cservenák <ta...@cservenak.net> wrote: > Howdy, > > In general looks ok (aside the plugin artifactId, that is a valid > concern), but here are few remarks: > * get rid org.apache.maven.shared.dependency.graph.DependencyGraphBuilder > (maven-dependency-tree). While not officially deprecated (yet), this > suffers from same issues as all other legacy/maven2 things (MAT for > example), (mis)uses project building request everywhere, uses deprecated > classes (ArtifactRepository), etc > * while not a problem per se, I find use of mojo-executor problematic, > especially in cases where the plugin invokes itself (RunMojo)? (the other > use is dependency:tree that could be replaced with that refactoring above) > * I'd avoid the use of mrm plugin. You already pull Jetty, simplest (and > most straightforward and least error prone) is to just fire up Jetty to > serve files from somewhere as "remote repository" as in that case you are > 100% in control of what is being served, while with MRM you are not. > > HTH > Tamas > > > On Fri, Jun 23, 2023 at 5:20 PM Basil Crow <m...@basilcrow.com> wrote: > >> I recently attempted to modernize the HPI plugin used in the Jenkins >> project: >> >> https://github.com/jenkinsci/maven-hpi-plugin >> >> This plugin has a Maven baseline of 3.8.1. I think I migrated all >> usages away from deprecated functionality and onto the recommended >> modern Maven functionality. >> >> If a Maven developer could audit this plugin and let me know if >> anything else should be updated, I would be grateful. >> >> Thanks, >> Basil >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >>
