Hi, On 14.11.23 14:16, Hervé Boutemy wrote:
no need to change the build prerequisite: just add a profile to activate the release flag on newer JDK: https://issues.apache.org/jira/browse/MPOM-447
Add another profile... it would be better to clean up those things and make clean upgrade way...instead ... Kind regards Karl Heinz Marbaise
Regards, Hervé Le lundi 13 novembre 2023, 20:38:00 CET Karl Heinz Marbaise a écrit :Hi, currently we have already the build requirements for Maven Core at JDK11+ So in consequence I would suggest to lift the minimum requirement for building plugins to JDK11. That means also we can use "--release 8" option (<maven.compiler.release>8</maven.compiler.release>) instead of source/target which is not correct based on the warnings we get like: "[WARNING] bootstrap class path not set in conjunction with -source 8" which we get in all plugins based on the configuration in maven parent using this: <javaVersion>8</javaVersion> <maven.compiler.source>1.${javaVersion}</maven.compiler.source> <maven.compiler.target>1.${javaVersion}</maven.compiler.target> which is not correct because we don't use animalsniffer anymore. So my suggestion is to lift the JDK build requirements to JDK11... and use the <maven.compiler.release>8</maven.compiler.release> which will prevent the warning. Also brings us back the safety net which animal-sniffer was before. Later on version of maven-parent (v42?) should change the whole configuration (there are some related parts like maven-pmd-plugin, maven-enforcer-plugin (enforce-byte-code max)..also toolchain-plugin... Furthermore we could get rid of the profile for JDK11+ related to spotless-maven-plugin ... Based on the upgrade to maven-parent v41 we could also enhance the build pipelines to build on JDK21 WDYT? Kind regards Karl Heinz Marbaise --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
