Le 2024-01-10 à 15 h 01, Tamás Cservenák a écrit :
IMO, add all. I think is fine, but PR discussion will decide anyway...
Created a JIRA task [1] and a pull request [2] after rebasing behind
latest Maven commit.
Note 1: the guideline shown when creating the pull request suggested to
put the JIRA issue number and title on the first line of the commit
message. But an unfortunate consequence of this policy is that the list
of commits in the pull request [2] shows the same line, repeated
identically for each commit. Not a big issue for me, but isn't
unconvenient for reviewers?
Note 2: there is no JUnit tests yet. Maybe they should be added before
the pull request is merged. Waiting to see what changes the discussion
may require before doing so.
Note 3: this pull request introduces a dependency to Java 9 and later,
because it needs to use the ModuleDescriptor class. I have not seen a
conclusion in the debate about which Java version Maven 4 should
require. If Java 8, a small part of this pull request will need to be
refactored as multi-version JAR file.
Martin
[1]https://issues.apache.org/jira/browse/MNG-8015
[2]https://github.com/apache/maven/pull/1378
