Ping, does anyone have any input on this? Would be much appreciated, Thanks, Konrad
> On 8. Jan 2024, at 19:16, Konrad Windszus <[email protected]> wrote: > > Hi, > > According to https://maven.apache.org/pom/maven/#the-format-profile the git > commits created through applying the spotless formatting should be ignored > via a .git-blame-ignore-revs file. This file is automatically evaluated by > GitHub blame view. This doesn’t work well if the formatting also does some > reordering of lines (most prominently through > https://github.com/diffplug/spotless/tree/main/plugin-maven#sortpom). An > example can be found in > https://github.com/apache/sling-parent/blame/master/sling-parent/pom.xml#L270 > which obviously shows a non-related commit in line 270 due to the ignored > reordering commit (this is a different ASF projects but follows the same > approach as Maven). > > The same may happen with reordering of lines in Java. > I am wondering if there is a better approach, or we should rather not > generally recommend to add those reformatting commits to > .git-blame-ignore-revs. WDYT? > Konrad --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
