Regardless of this patche fixing the bug or not, I think we could go a step further on the Eclipse project/nature/builder support. Let me explain better.
For the case of 'less intrusive' Eclipse plugins (like Checkstyle), I think the patch is fine. But that is not enough for plugins that takes more control of your eclipse workspace - there are some plugins, for instance, that creates some XML files or even copy other jars in your project. More than that, you might want to support multiple plugins in your project, according to each developer preference (or budget limitation). Take for instance web/J2EE development. There are many plugins available for the task, being MyEclipseIDE and Lomboz the most popular ones. It would be nice if the same maven-powered project could be used by any of these plugins. So, in those cases, we would have specific goals for each plugin. Something like:
maven eclipse:eclipse -> default java project maven eclispe:myeclipseide maven eclipse:lomboz ....and so on....
We would still apply dion's patch so we can manually define our project builders, but when we call these new goals, the goal itself would know what builders/nature it must use.
Another thing that would be useful is to define the web structure of your application (i.e., where the files are, which JARs should be in the libetc...) in the POM, so these plugins could create the right structure in place (for instance, copying the jars from $MAVEN_HOME to web/WEB-INF/lib). But this is not specfic to the Eclipse plug-in, it should be something 'maven-widely' (maybe the current POM model already supports it - I'm still a semi-newbie maven user, so sorry if it already does and I didn't know :-).
Finally, once we discuss this issue and decide if it is usefull or not (i.e., if a new patch would be accepted/committed in), I could open a new bug describing it and even work on the patches (in fact, I should have done that already, but been too busy to - right now we are just using the default eclipse:eclise goal and then manually using MyEclipseIDE to add a web-module on the project).
Regards,
Felipe
[EMAIL PROTECTED] wrote:
The following comment has been added to this issue:
Author: dion gillard Created: Tue, 4 May 2004 9:04 PM Body: This patch looks ok to me. It would be nice if we had a test case for it, but I can apply and test if everyone is ok with it
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
