Is there any downside with https://maven.apache.org/ref/3.9.8/maven-plugin-api/plugin.html#class_requirement no longer being maintained? How does the error message differ in case no according implementation can be found during execution for 1. and 2.?
I will do some more experiments and then create an according JIRA ticket for deprecation of the component annotation in https://issues.apache.org/jira/projects/MPLUGIN. At the same time we should probably deprecate https://github.com/apache/maven/blob/df94ee0d2c62c36d237deb04f42f75942d91d6cd/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/Requirement.java#L25C14-L25C25, WDYT @Guillaume? Thanks, Konrad > On 17. Jun 2024, at 13:25, Konrad Windszus <k...@apache.org> wrote: > > > Hi, > I am wondering about the best practice to inject Sisu/JSR330 components into > Mojos. > We have two different possibilities: > > 1. Via annotation org.apache.maven.plugins.annotations.Component [1] which > makes the referenced Sisu component also appear in the requirements section > of the plugin descriptor [3]. > 2. Via the JSR330 Inject annotation > > For the former I couldn’t find a way to use multi bindings [2] but the latter > does not affect the plugin descriptor [3], therefore error handling might be > inferior. > Any opinions/thoughts? > > Thanks in advance, > Konrad > > [1] - > https://maven.apache.org/plugin-tools/maven-plugin-annotations/apidocs/org/apache/maven/plugins/annotations/Component.html > [2] - https://github.com/google/guice/wiki/Multibindings > [3] - > https://maven.apache.org/ref/3.9.8/maven-plugin-api/plugin.html#class_requirement > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
